Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lalezar-fonts: init at unstable-2017-02-28 #59402

Closed
wants to merge 1 commit into from
Closed

lalezar-fonts: init at unstable-2017-02-28 #59402

wants to merge 1 commit into from

Conversation

LinArcX
Copy link
Contributor

@LinArcX LinArcX commented Apr 13, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@LinArcX
lalezar-fonts: init at unstable-2017-02-28
ab960dd 
lalezar-fonts: init at unstable-2017-02-28

lalezar-fonts: init at unstable-2017-02-28
@LinArcX
Copy link
Contributor Author

LinArcX commented Apr 14, 2019

@GrahamcOfBorg build lalezar-fonts

veprbl
veprbl reviewed Apr 14, 2019
View reviewed changes
pkgs/top-level/all-packages.nix
@@ -6552,9 +6555,6 @@ in
yaft = callPackage ../applications/misc/yaft { };

yarn = callPackage ../development/tools/yarn { };

yarn2nix = throw "Use upstream https://github.com/moretea/yarn2nix";
mkYarnPackage = yarn2nix;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@veprbl Done!

veprbl
veprbl reviewed Apr 14, 2019
View reviewed changes
pkgs/top-level/all-packages.nix
@@ -10,6 +10,7 @@ res: pkgs: super:

with pkgs;


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here

@veprbl veprbl closed this in 072c69f Apr 24, 2019
@LinArcX
Copy link
Contributor Author

LinArcX commented Apr 24, 2019

why closed?

@veprbl
Copy link
Member

veprbl commented Apr 24, 2019

@LinArcX You did not fix the spurious change, so I did it for you. This is in master now.

@LinArcX
Copy link
Contributor Author

LinArcX commented Apr 24, 2019

@veprbl Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LinArcX @veprbl @GrahamcOfBorg