New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mxisd: 1.2.0 -> 1.4.3 #59401
mxisd: 1.2.0 -> 1.4.3 #59401
Conversation
@mguentner Sorry for the delay on this. Do you mind doing a git rebase? Please keep in mind that |
@aanderse No worries. Thanks for taking a look. mxisd development has made some progress in the meantime: |
OK sounds good. I'll wait to hear back on a version update. |
@aanderse Ready :) |
@GrahamcOfBorg build mxisd |
So it appears someone has removed |
@aanderse Pushed |
@mguentner thanks! |
@mguentner can you briefly explain why the code in |
@aanderse That's why I opted for simply copying the config to the work directory. I used So it was done because of the configuration requirements of mxisd < 1.3, not because it mutates the config file during runtime. If an existing config has something in More on that: https://github.com/kamax-matrix/mxisd/wiki/Upgrade-Notes#v130 |
@mguentner you have been super helpful in my review of this change. Thank you! |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)cc @fpletz @hschaeidt 🕸️
I suggest to backport to 19.03