Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mxisd: 1.2.0 -> 1.4.3 #59401

Merged
merged 2 commits into from May 19, 2019
Merged

mxisd: 1.2.0 -> 1.4.3 #59401

merged 2 commits into from May 19, 2019

Conversation

mguentner
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @fpletz @hschaeidt 🕸️
I suggest to backport to 19.03

@aanderse
Copy link
Member

@mguentner Sorry for the delay on this. Do you mind doing a git rebase? Please keep in mind that PermissionsStartOnly has been deprecated.

@mguentner
Copy link
Contributor Author

mguentner commented May 13, 2019

@aanderse No worries. Thanks for taking a look.

mxisd development has made some progress in the meantime:
1.4.x seems stable enough. I will test it very soon.
I will might simply push to that branch and we can omit the 1.3.1.

@aanderse
Copy link
Member

OK sounds good. I'll wait to hear back on a version update.

@mguentner mguentner changed the title mxisd: 1.2.0 -> 1.3.1 mxisd: 1.2.0 -> 1.4.3 May 16, 2019
@mguentner
Copy link
Contributor Author

@aanderse Ready :)

@aanderse
Copy link
Member

@GrahamcOfBorg build mxisd
@GrahamcOfBorg test mxisd

@aanderse
Copy link
Member

So it appears someone has removed mxisd from nixos/tests/all-tests.nix 😞
@mguentner bonus points if you push another commit on top of this to add mxisd (back?) to all-tests.nix

@mguentner
Copy link
Contributor Author

@aanderse Pushed

@aanderse
Copy link
Member

@mguentner thanks!
@GrahamcOfBorg test mxisd

@aanderse
Copy link
Member

@mguentner can you briefly explain why the code in preStart is no longer required? It looks like you're moving from a mutable config file to immutable so are there any backward compatibility/upgrade issues to consider?

@mguentner
Copy link
Contributor Author

@aanderse
At some point mxisd required the config to be named application.yaml. Pointing it to the /nix/store path produced by writeText did not work because of the filename like hash-something-application.yaml.

That's why I opted for simply copying the config to the work directory. I used chmod 444 to prevent mutation.

So it was done because of the configuration requirements of mxisd < 1.3, not because it mutates the config file during runtime.
I don't expect / didn't run into any upgrade issues because of that.

If an existing config has something in extraConfig however, this might need to be adjusted as config format changed slightly. It's no longer some yaml-inspired format but standard-yaml.

More on that: https://github.com/kamax-matrix/mxisd/wiki/Upgrade-Notes#v130

@aanderse
Copy link
Member

@mguentner you have been super helpful in my review of this change. Thank you!

@aanderse aanderse merged commit b5a0c38 into NixOS:master May 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants