Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deepin.deepin-anything: init at 0.0.7 #59378

Merged
merged 2 commits into from May 5, 2019
Merged

deepin.deepin-anything: init at 0.0.7 #59378

merged 2 commits into from May 5, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Apr 13, 2019

Motivation for this change

Add deepin-anything, the Deepin file search tool.

It is dedicated to providing Linux users with a lightning-fast file name search function and offline search.

About packaging deepin for NixOS: #59023

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo
Copy link
Contributor Author

romildo commented Apr 13, 2019 •
edited

TODO:

  • It has a kernel module that has to be correctly installed.
  • It has a group/user that has to be setup.
  • It installs a dbus service and a systemd unit. A NixOS module may be a good idea.
  • It seems to have a plugin system that may need further investigation.
    The Deepin Anything Server seems to use an environment variable (DAS_PLUGIN_PATH) to determine where to look for plugins. Therefore nothing has to be fixed here. On the deepin and arch linux distributions it seems that only two files are installed there:
    • /usr/lib/deepin-anything-server-lib/plugins/handlers/libdde-anythingmonitor.so (from the dde-file-manager package)
    • /usr/lib/deepin-anything-server-lib/plugins/handlers/libupdate-lft.so (from the deepin-anything package)
  • Because of that:
    • a wrapper with plugins for deepin-anything will be needed. Would it give cyclic dependencies, considering that dde-file-manager depends on deepin-anything, but also installs a plugin for deepin-anything?
    • or DAS_PLUGIN_PATH will have to be set to /run/current-system/sw/lib/deepin-anything-server-lib/plugins in a module, and /lib/deepin-anything-server-lib/plugins will have to be added to pathsToLink.

@worldofpeace, what do you think?

@romildo
Copy link
Contributor Author

romildo commented Apr 13, 2019

It is a dependency for deepin-file-manager.

@romildo romildo requested a review from infinisil as a code owner April 14, 2019 02:24
@grahamc
Copy link
Member

grahamc commented Apr 14, 2019 •
edited

@GrahamcOfBorg eval

@romildo romildo changed the title [WIP] deepin.deepin-anything: init at 0.0.6 deepin.deepin-anything: init at 0.0.6 Apr 14, 2019
@romildo romildo changed the title deepin.deepin-anything: init at 0.0.6 deepin.deepin-anything: init at 0.0.7 Apr 20, 2019
@romildo
Copy link
Contributor Author

romildo commented Apr 21, 2019

The dbus service, systemd service, desktop module, group and user will be added to the nixos module in a forthcoming PR. It will depend on #59943.

@romildo romildo merged commit 1c137e3 into NixOS:master May 5, 2019
@romildo romildo deleted the upd.deepin.deepin-anything branch May 5, 2019 18:05
@romildo romildo mentioned this pull request May 5, 2019
Closed
76 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romildo @grahamc @GrahamcOfBorg