Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.azure-mgmt-network: remove patch #59614

Merged
merged 1 commit into from Apr 17, 2019
Merged

pythonPackages.azure-mgmt-network: remove patch #59614

merged 1 commit into from Apr 17, 2019

Conversation

asymmetric
Copy link
Contributor

@asymmetric asymmetric commented Apr 15, 2019 •
edited

The patched file has been removed in 0.

Motivation for this change

Was broken on master:

nix-build -A pythonPackages.azure-mgmt-network

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@asymmetric asymmetric requested a review from FRidh as a code owner April 15, 2019 16:12
@asymmetric
Copy link
Contributor Author

If this is accepted, it should be cherry-picked to 19.03 as well.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/nixops-travis-ci-test-failure-on-azure-private-ip-pr/2441/8

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.azure-mgmt-network python3.pkgs.azure-mgmt-network

@dotlambda dotlambda merged commit 6c6f13e into NixOS:master Apr 17, 2019
dotlambda pushed a commit that referenced this pull request Apr 17, 2019
@asymmetric
pythonPackages.azure-mgmt-network: remove patch (#59614)
4c62718 
The patched file has been removed in [0].

 [0]: Azure/azure-sdk-for-python@09b09a5

(cherry picked from commit 6c6f13e)
@asymmetric asymmetric deleted the azure-mgmt-remove-patch branch April 17, 2019 22:42
@asymmetric asymmetric restored the azure-mgmt-remove-patch branch April 17, 2019 22:50
@asymmetric asymmetric mentioned this pull request Apr 17, 2019
Merged
@asymmetric asymmetric deleted the azure-mgmt-remove-patch branch April 17, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmineChikhaoui AmineChikhaoui AmineChikhaoui approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@asymmetric @nixos-discourse @dotlambda @AmineChikhaoui @GrahamcOfBorg