Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] xonsh: 0.8.3 -> 0.8.12 #59509

Merged
merged 1 commit into from Apr 14, 2019
Merged

[19.03] xonsh: 0.8.3 -> 0.8.12 #59509

merged 1 commit into from Apr 14, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Apr 14, 2019

(cherry picked from commit aa4af91)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau timokau mentioned this pull request Apr 14, 2019
Merged
10 tasks
@Ma27
Copy link
Member

Ma27 commented Apr 14, 2019

Built and tested locally 👍
Let's wait for ofborg to finish and mergen then.

@timokau
Copy link
Member Author

timokau commented Apr 14, 2019

Not waiting for darwin since it seems overloaded today.

@timokau timokau merged commit b8debac into NixOS:release-19.03 Apr 14, 2019
@timokau timokau deleted the xonsh-0.8.12-backport branch April 14, 2019 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrthra vrthra Awaiting requested review from vrthra

@garbas garbas Awaiting requested review from garbas

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timokau @Ma27 @GrahamcOfBorg @Meptl