Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

numatop: init at 2.1 #59501

Merged
merged 3 commits into from Apr 17, 2019
Merged

numatop: init at 2.1 #59501

merged 3 commits into from Apr 17, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 14, 2019

Motivation for this change

Useful utility.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

markuskowa
markuskowa reviewed Apr 14, 2019
View reviewed changes
Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tool requires root access. Is this intended?

pkgs/os-specific/linux/numatop/default.nix Outdated Show resolved Hide resolved
@dtzWill
Copy link
Member Author

dtzWill commented Apr 14, 2019

The tool requires root access. Is this intended?

I think so? :).

@markuskowa
Copy link
Member

The platform should be restricted to x86_64-linux. Since the tool is provided by intel it may not be intended to work on ARM.

@markuskowa markuskowa merged commit 3884afa into NixOS:master Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @markuskowa @GrahamcOfBorg