New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keepassxc: 2.4.0 -> 2.4.1 #59511
keepassxc: 2.4.0 -> 2.4.1 #59511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to build and run this on NixOS, but have not tried KeeShare (nor OSX).
++ (optional withKeePassHTTP "-DWITH_XC_HTTP=ON") | ||
++ (optional withKeePassKeeShare "-DWITH_XC_KEESHARE=ON") | ||
++ (optional withKeePassKeeShare "-DQUAZIP_INCLUDE_DIR=${quazip}/include/quazip") | ||
++ (optional withKeePassKeeShare "-DQUAZIP_LIBRARIES=${quazip}/lib/libquazip.so") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not had time to test this yet. Is this compatible with OSX?
Would it be possible to 'automatically' find this using pkg-config
by adding ? It seems keepass does have such functionality: https://github.com/keepassxreboot/keepassxc/blob/b59fd6d06ad0b130c00c8afe8e003999335afd21/cmake/FindQuaZip.cmakequazip
to the buildInputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to use pkg-config
. That required an additional line in the patch, but it's probably cleaner overall.
KeeShare was already being built, I've just moved it to optional to match what KeePassXC's cmake setup supports. There was a bug in the 2.4.0 release that prevented building without this enabled. |
fd083c5
to
acb1c8b
Compare
KeePassXC has a new release. Changelog at https://github.com/keepassxreboot/keepassxc/releases/tag/2.4.1. Additionally, some cleanup: - Alphabetize inputs for better future diffs - Drop a no-longer-relevant patch - Fixup removed and missing cmake flags - Update description to reference correct browser extension
acb1c8b
to
a3b39e2
Compare
Sounds good 👍 Works fine on OSX as well btw. |
Motivation for this change
KeePassXC has a new release. Changelog at
https://github.com/keepassxreboot/keepassxc/releases/tag/2.4.1.
Additionally, some cleanup:
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)