python3Packages.poetry: 0.12.10 -> 0.12.12 #59506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costrouc
approved these changes
Apr 14, 2019
costrouc
suggested changes
Apr 14, 2019
There was a problem hiding this comment.
Don't know now to remove approval. Does not build on python 2.7. Used nix-review.
builder for '/nix/store/4b9x2hgl7xvrwrpxkm3589mz7nabjqb8-python2.7-poetry-0.12.12.drv' failed with exit code 1; last 10 log lines:
Successfully built poetry
Finished creating a wheel...
installing
/build/poetry-0.12.12/dist /build/poetry-0.12.12
DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7.
Processing ./poetry-0.12.12-py2-none-any.whl
Requirement already satisfied: virtualenv<17.0,>=16.0; python_version >= "2.7" and python_version < "2.8" in /nix/store/3h3n6yqjp1jjbl8jd4nibpk8vmv68px6-python2.7-virtualenv-16.4.1/lib/python2.7/site-packages (from poetry==0.12.12) (16.4.1)
Collecting glob2<0.7,>=0.6; python_version >= "2.7" and python_version < "2.8" or python_version >= "3.4" and python_version < "3.5" (from poetry==0.12.12)
Could not find a version that satisfies the requirement glob2<0.7,>=0.6; python_version >= "2.7" and python_version < "2.8" or python_version >= "3.4" and python_version < "3.5" (from poetry==0.12.12) (from versions: )
No matching distribution found for glob2<0.7,>=0.6; python_version >= "2.7" and python_version < "2.8" or python_version >= "3.4" and python_version < "3.5" (from poetry==0.12.12)
cannot build derivation '/nix/store/ap9jvbak0nzba2gd56j82dyq1vahj6m7-env.drv': 1 dependencies couldn't be built
[2 built (1 failed), 150 copied (402.1 MiB), 86.2 MiB DL]
|
Looks great to me. Passed nix-review. |
|
jsonschema has a |
FRidh
reviewed
May 28, 2019
| @@ -45,6 +46,8 @@ in buildPythonPackage rec { | |||
| "requests-toolbelt>=0.8.0,<0.10.0" | |||
| ''; | |||
|
|
|||
| format = "pyproject"; | |||
|
This also looks good to me, what needs to happen to merge this? |
This was referenced Jul 3, 2019
|
@jbaum98 I suggested #59506 (comment) |
|
I upgraded Result of 163 package failed to build:
84 package were build:
|
|
This would be the only case where I'd actually see packages already failing to build being positive 🤣 As I suspected the bump probably causes breakages. |
|
pushed 5102201 |
|
For jsonschema (and other packages) we should run a job using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://github.com/sdispater/poetry/releases/tag/0.12.12
https://github.com/sdispater/poetry/releases/tag/0.12.11
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)