Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boost: fix 1.55 build on macOS #59508

Merged
merged 1 commit into from Apr 16, 2019
Merged

boost: fix 1.55 build on macOS #59508

merged 1 commit into from Apr 16, 2019

Conversation

strager
Copy link
Contributor

@strager strager commented Apr 14, 2019

Motivation for this change

darwin-no-system-python.patch does not apply cleany on Boost 1.55's sources. Fix this patch file for Boost 1.55, making it build on Darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@strager
boost: fix 1.55 build on macOS
3edb8ad 
darwin-no-system-python.patch does not apply cleany on Boost 1.55's
sources. Fix this patch file for Boost 1.55, making it build
successfully on macOS.
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Apr 14, 2019
@GrahamcOfBorg GrahamcOfBorg requested a review from peti April 14, 2019 19:23
@veprbl
Copy link
Member

veprbl commented Apr 16, 2019

@GrahamcOfBorg build boost155

@veprbl veprbl added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 16, 2019
@veprbl veprbl merged commit 153e7fc into NixOS:master Apr 16, 2019
veprbl pushed a commit that referenced this pull request Apr 16, 2019
@strager @veprbl
boost: fix 1.55 build on macOS (#59508)
2db665b 
darwin-no-system-python.patch does not apply cleany on Boost 1.55's
sources. Fix this patch file for Boost 1.55, making it build
successfully on macOS.

(cherry picked from commit 153e7fc)
veprbl pushed a commit that referenced this pull request Apr 16, 2019
@strager @veprbl
boost: fix 1.55 build on macOS (#59508)
2aa505b 
darwin-no-system-python.patch does not apply cleany on Boost 1.55's
sources. Fix this patch file for Boost 1.55, making it build
successfully on macOS.

(cherry picked from commit 153e7fc)
@veprbl veprbl added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Apr 16, 2019
@strager strager deleted the boost-155 branch April 18, 2019 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@strager @veprbl @GrahamcOfBorg