[Background Sync] Add 'periodic-background-sync' permission. #16351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 15, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1567748
branch
5 times, most recently
from
66326a2
to
09db94e
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1567748
branch
7 times, most recently
from
a70b58e
to
bb69700
Compare
This CL adds a permission and a feature flag for Periodic Background Sync. The permission will be denied when the feature is disabled, which is true by default while we're implementing it. We currently only grant the permission if accessed from a secure origin. Unit tests and a web test have also been added. Future CLs will add more logic to PeriodicBackgroundSyncPermissionContext. Bug: 925297 Change-Id: I41e8d692a8bea9c356dad8681a8c79e23d7eda4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567748 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#655961}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1567748
branch
from
bb69700
to
06fd04e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds a permission and a feature flag for Periodic Background Sync.
The permission will be denied when the feature is disabled, which is true by
default while we're implementing it. We currently only grant the permission
if accessed from a secure origin.
Unit tests and a web test have also been added.
Future CLs will add more logic to PeriodicBackgroundSyncPermissionContext.
Bug: 925297
Change-Id: I41e8d692a8bea9c356dad8681a8c79e23d7eda4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567748
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#655961}