Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tomb: add sudo to buildInputs #59361

Merged
merged 1 commit into from Apr 12, 2019
Merged

tomb: add sudo to buildInputs #59361

merged 1 commit into from Apr 12, 2019

Conversation

bricewge
Copy link
Contributor

Motivation for this change

This fix the evaluation of tomb package as reported here: #57946 (comment).
In installCheckPhase stderr is not masked anymore, that way it's easier to understand why it fail.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bricewge bricewge mentioned this pull request Apr 12, 2019
Merged
10 tasks
etu
etu reviewed Apr 12, 2019
View reviewed changes
Copy link
Contributor

@etu etu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to add sudo to the wrapProgram down on line 34 as well?

@bricewge
Copy link
Contributor Author

No it works well without it.

@adisbladis
Copy link
Member

@etu Wrapping sudo would not work anyway since it needs setuid to work.

@adisbladis
Copy link
Member

@GrahamcOfBorg build tomb

@adisbladis adisbladis merged commit 917a7fa into NixOS:master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu etu left review comments

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bricewge @adisbladis @etu @GrahamcOfBorg