Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boost 170: init at 1.70.0 #59602

Merged
merged 1 commit into from May 6, 2019
Merged

boost 170: init at 1.70.0 #59602

merged 1 commit into from May 6, 2019

Conversation

amirshavit
Copy link
Contributor

@amirshavit amirshavit commented Apr 15, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@amirshavit amirshavit changed the title boost170: init at 1.70.0 boost 170: init at 1.70.0 Apr 15, 2019
@veprbl
Copy link
Member

veprbl commented Apr 15, 2019

@GrahamcOfBorg build boost170

@dtzWill
Copy link
Member

dtzWill commented Apr 15, 2019

Safe enough since this only adds new top-level attributes for the new version (as is our custom re:boost, for better or for worse :)).

I gave this a go earlier (bumping from 1.69 as default, FWIW) and quickly found unusually high number of failures.

Long story short, I suggest adding something like ++ optional (versionOlder "1.70" version) "--no-cmake-config" to b2Args, to avoid all the pain.

@amirshavit
Copy link
Contributor Author

Boost 1.70 introduces several breaking changes (unfortunately not all are trivially spottable in the changelog). IMO disabling the CMake configuration files will cause harm in the longer term.

@amirshavit
Copy link
Contributor Author

Can this be merged please?

@veprbl
Copy link
Member

veprbl commented May 2, 2019

cc @peti

@peti peti merged commit 3039b8d into NixOS:master May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@amirshavit @veprbl @dtzWill @peti @GrahamcOfBorg