Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.annexremote: init at 1.3.1 #59463

Merged
merged 4 commits into from Apr 14, 2019
Merged

pythonPackages.annexremote: init at 1.3.1 #59463

merged 4 commits into from Apr 14, 2019

Conversation

montag451
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@montag451 montag451 requested a review from FRidh as a code owner April 14, 2019 11:07
dotlambda
dotlambda requested changes Apr 14, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran 0 tests in 0.000s

Please add an appropriate checkPhase. You might have to use fetchFromGitHub. In that case, please ask upstream to include the tests in their PyPI tarballs in the future.

pkgs/development/python-modules/annexremote/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/annexremote/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/annexremote/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/annexremote/default.nix Outdated Show resolved Hide resolved
@dotlambda dotlambda changed the title annexremote: init at 1.3.1 pythonPackages.annexremote: init at 1.3.1 Apr 14, 2019
dotlambda
dotlambda requested changes Apr 14, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message needs to be corrected.

@montag451
Copy link
Contributor Author

@dotlambda I tried to address all your remarks in 5cc82aa

@dotlambda
Copy link
Member

In that case, please ask upstream to include the tests in their PyPI tarballs in the future.

I did this for you in https://github.com/Lykos153/AnnexRemote/pulls.

The commit message needs to be corrected.

I'll also do that for you when squashing.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.annexremote python3.pkgs.annexremote

dotlambda
dotlambda requested changes Apr 14, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error: build of '/nix/store/l3dpg0z5qmnddgz67vrhjg9anmxq3cnv-python2.7-annexremote-1.3.1.drv' failed

@montag451
Copy link
Contributor Author

Build failure fixed. See 7a7ec74

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.annexremote python3.pkgs.annexremote

@dotlambda dotlambda merged commit c82ebc1 into NixOS:master Apr 14, 2019
@montag451 montag451 deleted the annexremote branch April 14, 2019 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@montag451 @dotlambda @GrahamcOfBorg