Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.humanfriendly: init at 4.18 #59466

Merged
merged 4 commits into from Apr 15, 2019
Merged

pythonPackages.humanfriendly: init at 4.18 #59466

merged 4 commits into from Apr 15, 2019

Conversation

montag451
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@montag451 montag451 requested a review from FRidh as a code owner April 14, 2019 11:35
@dotlambda dotlambda changed the title humanfriendly: init at 4.18 pythonPackages.humanfriendly: init at 4.18 Apr 14, 2019
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.humanfriendly python3.pkgs.humanfriendly

dotlambda
dotlambda requested changes Apr 14, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No matching distribution found for monotonic; python_version == "2.6" or python_version == "2.7" or python_version == "3.0" or python_version == "3.1" or python_version == "3.2" (from humanfriendly==4.18)

@montag451
Copy link
Contributor Author

Build failure fixed in 984a356

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.humanfriendly python3.pkgs.humanfriendly

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.humanfriendly python3.pkgs.humanfriendly

@dotlambda dotlambda merged commit b18719f into NixOS:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@montag451 @dotlambda @GrahamcOfBorg