Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stretchly: init at 0.19.1 #59383

Merged
merged 2 commits into from Apr 17, 2019
Merged

stretchly: init at 0.19.1 #59383

merged 2 commits into from Apr 17, 2019

Conversation

cdepillabout
Copy link
Member

This commit adds the program stretchly:

https://github.com/hovancik/stretchly

stretchly is an Electron app. Like other Electron apps in nixpkgs, this derivation just packages the binary version for Linux and rewrites rpaths with patchelf. Eventually it would be nice to actually package the source version of stretchly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
stretchly: init at 0.19.1
e48cfb5 
This commit adds the program `stretchly`:

https://github.com/hovancik/stretchly

`stretchly` is an Electron app, so this commit just packages the binary
version for Linux.
@cdepillabout
Copy link
Member Author

@GrahamcOfBorg build stretchly

tomberek
tomberek approved these changes Apr 14, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, runs, functions as expected. (Ubuntu)

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/12

@cdepillabout
Copy link
Member Author

@GrahamcOfBorg build stretchly

@timokau timokau merged commit 96fa447 into NixOS:master Apr 17, 2019
@timokau
Copy link
Member

timokau commented Apr 17, 2019

Thanks!

@cdepillabout cdepillabout deleted the add-stretchly branch April 18, 2019 00:28
@cdepillabout cdepillabout mentioned this pull request Apr 18, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cdepillabout @nixos-discourse @timokau @tomberek @GrahamcOfBorg