Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automysqlinit: init at 3.0_rc6 #59381

Merged
merged 1 commit into from Apr 22, 2019
Merged

automysqlinit: init at 3.0_rc6 #59381

merged 1 commit into from Apr 22, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Apr 13, 2019 •
edited

Motivation for this change

The DBAs at work use this on Debian and asked me to put this script into a cronjob on the new NixOS boxes. I thought I'd do one better and write a configurable service.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member Author

aanderse commented Apr 13, 2019 •
edited

@GrahamcOfBorg test automysqlbackup

@aanderse aanderse force-pushed the automysqlbackup branch 4 times, most recently from 090225d to 53b0d0c Compare April 14, 2019 13:34
infinisil
infinisil requested changes Apr 15, 2019
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice module, actually even enjoyed reviewing this

nixos/modules/services/backup/automysqlbackup.nix Outdated Show resolved Hide resolved
nixos/modules/services/backup/automysqlbackup.nix Outdated Show resolved Hide resolved
nixos/modules/services/backup/automysqlbackup.nix Outdated Show resolved Hide resolved
nixos/modules/services/backup/automysqlbackup.nix Show resolved Hide resolved
pkgs/tools/backup/automysqlbackup/default.nix Show resolved Hide resolved
@aanderse
Copy link
Member Author

Very nice module, actually even enjoyed reviewing this

I'm very glad to hear that. It was fun trying out a new backend (bash) for a config property that I've never considered before this.

I'll note I made one change in my latest push which wasn't part of your review. I added mysql_dump_single_transaction = true; to the default config which appears to be a better fit after some more real world testing. Of course users are free to change as they see fit.

@aanderse aanderse merged commit c3f69d1 into NixOS:master Apr 22, 2019
@aanderse aanderse deleted the automysqlbackup branch April 22, 2019 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil requested changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @infinisil @GrahamcOfBorg