Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/hostapd: escape interface names for hostapd #59367

Merged
merged 1 commit into from May 3, 2019
Merged

nixos/hostapd: escape interface names for hostapd #59367

merged 1 commit into from May 3, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Apr 12, 2019 •
edited

Motivation for this change

Same problem as described in acbadcd.

When using multiple interfaces for wifi with networking.wlanInterfaces
and the interface for hostapd contains a dash, this will fail as
systemd escapes dashes in its device names.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
nixos/hostapd: escape interface names for hostapd
f975bba 
Same problem as described in acbadcd.

When using multiple interfaces for wifi with `networking.wlanInterfaces`
and the interface for `hostapd` contains a dash, this will fail as
systemd escapes dashes in its device names.
@Ma27 Ma27 requested a review from infinisil as a code owner April 12, 2019 17:29
@infinisil infinisil added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 12, 2019
@c0bw3b c0bw3b merged commit 966ee25 into NixOS:master May 3, 2019
@Ma27 Ma27 deleted the fix-hostapd-interface-naming branch May 3, 2019 17:27
@Ma27
Copy link
Member Author

Ma27 commented May 3, 2019

@c0bw3b thanks! Can you also backport to release-19.03? :)

@c0bw3b
Copy link
Contributor

c0bw3b commented May 3, 2019

@Ma27 yes I'm going to backport along with other fixes :)

@c0bw3b c0bw3b mentioned this pull request May 3, 2019
Merged
10 tasks
c0bw3b added a commit that referenced this pull request May 3, 2019
@c0bw3b
Merge pull request #60880 from c0bw3b/backport/1903/fixes
3b5974a 
[19.03] backport fixes from #59367, #60638, #60832
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ma27 @c0bw3b @markuskowa @infinisil @GrahamcOfBorg