Fixed flaky WebXR outputContext test #16338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 12, 2019
Promise test wasn't actually returning a promise, so the actual test logic was frequently being skipped by the test runners. Bug: 951553 Change-Id: I3b036b5b2dbb4edc347d2a94fe507b25681db4cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565248 Auto-Submit: Brandon Jones <bajones@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#651034}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1565248
branch
from
ea518f6
to
1699822
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promise test wasn't actually returning a promise, so the actual test
logic was frequently being skipped by the test runners.
Bug: 951553
Change-Id: I3b036b5b2dbb4edc347d2a94fe507b25681db4cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565248
Auto-Submit: Brandon Jones <bajones@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651034}