lib: improve the implementation of the unique function #59369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Nice! |
NeQuissimus
approved these changes
Apr 12, 2019
|
The real question about |
lheckemann
reviewed
Apr 13, 2019
There was a problem hiding this comment.
Change LGTM, but as @edolstra says maybe we don't want this function at all… So I'm going to have a look at where it's used.
lib/types.nix: merging enum types. Could probably be left out, at the cost of making enum type checks more expensive in probably rare cases?pkgs/top-level/python-packages.nix: inrequiredPythonModules, which seems to be a rather odd way of computing a closure on python package dependencies. Used transitively in lots of places maybe?pkgs/top-level/lua-packages.nix: inrequiredLuaModuleswhich seems to be a copy-paste of the python thing.nixos/modules/tasks/network-interfaces.nix: for something I don't quite understand (what's the difference between a WLAN interface and a WLAN device?)pkgs/build-support/fetchdocker/default.nix: getting each layer only once or something? This could probably be moved to build time?pkgs/misc/vim-plugins/vim-utils.nix: computing the transitive dependency closure of a pluginpkgs/games/factorio/utils.nix: more transitive dependency closure stuffpkgs/stdenv/generic/make-derivation.nix: for impure host depspkgs/development/java-modules/build-maven-package.nix: looks like more transitive dependency closure stuffpkgs/development/beam-modules/build-rebar3.nix: removing duplicates frompropagatedBuildInputsnixos/modules/services/networking/firewall.nix: for normalising lists of ports. In this case it's sorted as well so the uniqueness check could be simplified.nixos/modules/services/x11/gdk-pixbuf.nix: unique-ing the packages to generate a loader cache for. Could be done with sorting and moved to build time AFAICT.nixos/modules/tasks/filesystems/zfs.nix: getting the list of pools without duplicates from the list of filesystems. Generates some bash code directly from these. Could maybe be moved to build time, but it's a bit more complicated since these values are used in multiple places.nixos/modules/services/hardware/udev.nix: removing duplicates for udev packages for making the combined udev rule package. Could probably be moved to build time cheaply.nixos/modules/services/misc/mesos-slave.nix: could be moved into a build-time or runtime script.pkgs/build-support/rust/build-rust-crate/default.nix: dependency closure stuffpkgs/servers/sip/freeswitch/default.nix: buildInputs uniqueness. Not necessary I think?pkgs/applications/video/kodi/plugins.nix: dependency closure stuffpkgs/tools/networking/envoy/default.nix: getting multiple relevant outputs of some package but not the same one multiple timespkgs/applications/networking/cluster/terraform/default.nix: dependency closure stuffpkgs/applications/science/math/sage/sage-with-env.nix: dependency closure stuff
I may have overlooked one or two cases. I'm also not sure how useful this list is… But hey, at least we have it now :p
|
@GrahamcOfBorg eval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
http://gsc.io/graph.unstable.svg
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)