New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graalvm: rc8->rc15 #59371
graalvm: rc8->rc15 #59371
Conversation
Nice! This looks good to me, I currently cannot test this though. Thank you for the effort. I would change the license. |
So I've changed the license and the review from @volth, still a good reason to look over this again. I've simplified the install process. There was a folder with a super long name starting with graalvm sitting in mxbuild directory that has the directory setup all correct, plus it includes all the binaries (native-image, lli, js etc). I made an attempt to add fastr, truffleruby and pythongraal polyglots, but for now only succeded with python. Trying to compile fastr is out of my league, as it's using java via truffle-ffi to make a sharedlibfile (this case libR.so) and run it. I've run out of time trying to solve it, maybe truffleruby is easier, but I really need to do other stuff for the next 1 1/2 week. I'll paste here below the commands that I didn't include in this derivation, but were needed to get the build process further. (probably a memo to my future self, but please anyone reading this, have a go at this)
|
Motivation for this change
graal is constantly changeing, and the mx build tool is becoming more important and complex. It took me a week to get this working. Few things off the bat, I use openjdk instead of oraclejdk, reason is simply that the newest openjdk works with graalvm-1.0.0rc15 but oraclejdk does not. So that means I should change the license to GPL-2.0?
To build graalvm, I used heavily patched mx I named it mx-internal. This patched mx file is probably so patched that it's not unlikely that its intended default behavior is affected (building into home directories could be useful for example), so the vanilla mx command should work like documented.
Things done
Bumped mx, jvmci8 and graalvm. Patched mx and graalvm when needed. Added graaljs and intend to add fastr, pythongraal and more polyglot packages. Bumped all the jar dependencies by hand, this all took quite some time, kudos to @volth for their initial work. Like with previous graal nix-expression, this does not produce Sulong's
lli
binary, I'm now looking into how to get that working.sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)