Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.tinycss2: 0.6.1 -> 1.0.2 #59425

Merged
merged 1 commit into from Apr 15, 2019
Merged

pythonPackages.tinycss2: 0.6.1 -> 1.0.2 #59425

merged 1 commit into from Apr 15, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Apr 13, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eadwu eadwu requested a review from FRidh as a code owner April 13, 2019 22:29
@worldofpeace
Copy link
Contributor

Changelog: https://github.com/Kozea/tinycss2/blob/master/CHANGES

worldofpeace
worldofpeace suggested changes Apr 13, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Drop Python 2.7, 3.3 and 3.4 support.

We should use the disabled parameter of buildPython* to respect this.
I'm seeing the expression set LC_ALL = "en_US.UTF-8"; and that shouldn't be needed anymore.

Lastly this has pytestrunner as a setup_requires. I'm partial to patching that away since it's only needed for testing. See this patch. Then it can be a checkInputs properly.

@eadwu eadwu force-pushed the pythonPackages.tinycss2/1.0.2 branch from e9fea55 to e7a2ba8 Compare April 13, 2019 23:45
@eadwu eadwu mentioned this pull request Apr 14, 2019
Merged
10 tasks
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build python37Packages.cairosvg python37Packages.cssselect2 python35Packages.tinycss2 python36Packages.tinycss2 python3Packages.tinycss2

@eadwu eadwu force-pushed the pythonPackages.tinycss2/1.0.2 branch from e7a2ba8 to 08ba4b4 Compare April 14, 2019 12:19
@worldofpeace worldofpeace merged commit ef54604 into NixOS:master Apr 15, 2019
@worldofpeace
Copy link
Contributor

Thanks @eadwu

@eadwu eadwu deleted the pythonPackages.tinycss2/1.0.2 branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eadwu @worldofpeace @infinisil @GrahamcOfBorg