Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

journalwatch: fix broken package, general maintenance #59424

Merged
merged 3 commits into from Apr 27, 2019
Merged

journalwatch: fix broken package, general maintenance #59424

merged 3 commits into from Apr 27, 2019

Conversation

florianjacob
Copy link
Contributor

@florianjacob florianjacob commented Apr 13, 2019 •
edited by aanderse

Motivation for this change

The journalwatch package is broken on 19.03, as the now more strict dependency handling of buildPythonPackage uncovered the error of having pytest as buildInput instead of checkInput. This PR fixes that, along with some general maintenance:

The ee20ba8 fix pytest checks commit requires a backport to 19.03 to unbreak the package, the other commits are nice to have and should be backwards-compatible, but are not required. I'm sorry I did not notice the breakage prior release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This was referenced Apr 13, 2019
Open
Merged
@florianjacob florianjacob force-pushed the journalwatch branch 3 times, most recently from cd57b2d to d5e303c Compare April 13, 2019 22:12
aanderse
aanderse requested changes Apr 14, 2019
View reviewed changes
nixos/modules/services/logging/journalwatch.nix Outdated Show resolved Hide resolved
pkgs/tools/system/journalwatch/default.nix Outdated Show resolved Hide resolved
nixos/modules/services/logging/journalwatch.nix Outdated Show resolved Hide resolved
@florianjacob
Copy link
Contributor Author

@aanderse Thanks for your review, it was very helpful! 🍻

@florianjacob
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.journalwatch

@aanderse
Copy link
Member

@Ekleog I'm a big fan of your `system-sendmail' package. How do you feel about c29abbc?

@flokli
Copy link
Contributor

flokli commented Apr 27, 2019

@aanderse system-sendmail looks nice - didn't know it so far.
I guess it makes sense to use it in journalwatch, too :-)

Maybe we want to change other places referencing /run/wrappers/bin/sendmail directly too? (in a followup PR)

@aanderse aanderse merged commit 8d64ec7 into NixOS:master Apr 27, 2019
@aanderse
Copy link
Member

@flokli that sounds good. Hopefully at some point I'll circle back to that.
@florianjacob awesome job!

@florianjacob florianjacob deleted the journalwatch branch April 30, 2019 07:32
@florianjacob florianjacob mentioned this pull request Jun 24, 2019
Merged
@florianjacob
Copy link
Contributor Author

Forgot the backporting, PR at #59424.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli left review comments

@aanderse aanderse aanderse approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@florianjacob @aanderse @flokli @GrahamcOfBorg