Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport Haddock typechecker plugins fix #59583

Closed
wants to merge 1 commit into from
Closed

Backport Haddock typechecker plugins fix #59583

wants to merge 1 commit into from

Conversation

Taneb
Copy link
Contributor

@Taneb Taneb commented Apr 15, 2019

Closes #59317.

(cherry picked from commit a184604)

Reason: this should be strictly a bug fix, to allow using Haddock and doctest with type-checker plugins.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ghc-8.6.4: patch to fix haddock bug with typechecker plugins
8431053 
Closes NixOS#59317.

(cherry picked from commit a184604)

Reason: this should be strictly a bug fix, to allow using Haddock and
doctest with type-checker plugins.
@Taneb Taneb force-pushed the haddock-typechecker-plugins-fix-backport branch from 7c04ce3 to 8431053 Compare June 11, 2019 09:38
@Taneb Taneb closed this Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti peti is a code owner

@ryantm ryantm Awaiting requested review from ryantm ryantm is a code owner

@kosmikus kosmikus Awaiting requested review from kosmikus

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Taneb @GrahamcOfBorg