mautrix-telegram: patch away alembic dependency #59519
Conversation
|
As the package maintainer gave a 👍 I guess this should be fine. I'll merge this PR in a week unless there are further comments :) |
|
@worldofpeace I have to admit that I didn't read the thread when this was packaged initially, this is actually the result of something I used to have in an overlay in my deployment repo that seemed useful to upstream :)
I actually confirmed that |
I think doing But now I'm thinking, how is a user going to know that they need to use |
Whenever you need
That's indeed a good question. I guess not (atm), but this should be fixable by |
I believe that should be correct. |
`alembic`[1] is a database migration tool which is invoked from the CLI when installing the telegram bridge, but never needed during the runtime. The reason why `alembic` is required here is to ensure that it exists in the Python environment when deploying the bridge. However `alembic` requires `mautrix-telegram` in its environment to create a database schema from the Python models. Such a dependency relation may be possible with tools like virtualenv, however it'll result in an infinite recursion at evaluation time in Nix. With this patch, `mautrix-telegram` doesn't depend on `alembic` anymore and provides a patched alembic (`pkgs.mautrix-telegram.alembic`) which has `mautrix-telegram` in its path. [1] https://alembic.sqlalchemy.org/en/latest/
Ma27
force-pushed
the
improve-mautrix-telegram
branch
from
edfdc23
to
0a94f89
Compare
|
@worldofpeace ack, fixed :) |
|
As announced, I'll merge this now. It's been approved by a collaborator and got a thumbs-up from the package maintainer. Also, |
|
Thanks for being so thorough ✨ |
Motivation for this change
alembic[1] is a database migration tool which is invoked from the CLIwhen installing the telegram bridge, but never needed during the
runtime.
The reason why
alembicis required here is to ensure that itexists in the Python environment when deploying the bridge. However
alembicrequiresmautrix-telegramin its environment to create adatabase schema from the Python models.
Such a dependency relation may be possible with tools like virtualenv,
however it'll result in an infinite recursion at evaluation time in Nix.
With this patch,
mautrix-telegramdoesn't depend onalembicanymoreand provides a patched alembic (
pkgs.mautrix-telegram.alembic) whichhas
mautrix-telegramin its path.[1] https://alembic.sqlalchemy.org/en/latest/
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)