Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/dde-daemon: init #59520

Merged
merged 1 commit into from Apr 15, 2019
Merged

nixos/dde-daemon: init #59520

merged 1 commit into from Apr 15, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Apr 14, 2019 •
edited

Motivation for this change

Add a NixOS service for deepin-daemon.

About packaging deepin for NixOS: #59023

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo romildo requested a review from infinisil as a code owner April 14, 2019 20:35
@romildo romildo changed the title nixos/deepin-daemon: init nixos/dde-daemon: init Apr 14, 2019
worldofpeace
worldofpeace reviewed Apr 14, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the output of dde-daemon they're some other things
we need to care for.

  • .png at /var/cache/thumbnail
    Don't think we can get those file to an installed
    system. Perhaps hardcode them in the source.

  • share/pam-configs etc/pam.d
    This is configuration for some sort of
    pam module dde-authority-pam

  • /var/lib/polkit-1/localauthority/10-vendor.d/
    See: https://www.freedesktop.org/software/polkit/docs/0.105/pklocalauthority.8.html
    I don't see anywhere in NixOS how this would be handled.
    Perhaps we can install them to etc/polkit-1/localauthority
    and use environment.etc.

nixos/modules/services/desktops/deepin/dde-daemon.nix Outdated Show resolved Hide resolved
@romildo
Copy link
Contributor Author

romildo commented Apr 15, 2019 •
edited

Looking at the output of dde-daemon they're some other things
we need to care for.

I think it is better to handle those issues outside of this PR.

Edit: I have started listing issues in the DDE tracking issue: #59023

@romildo romildo mentioned this pull request Apr 15, 2019
Closed
76 tasks
@worldofpeace
Copy link
Contributor

Looking at the output of dde-daemon they're some other things
we need to care for.

I think it is better to handle those issues outside of this PR.

Edit: I have started listing issues in the DDE tracking issue: #59023

Nice.

Note that it was a comment not a requested change.
There's many things to fix, and can't all be done simultaneously.

@romildo romildo merged commit c32b50a into NixOS:master Apr 15, 2019
@romildo romildo deleted the upd.deepin.deepin-daemon branch April 15, 2019 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romildo @worldofpeace @GrahamcOfBorg