Add: Warn players that company passwords are not truly secure #7351
Conversation
nielsmh
force-pushed
the
password-warning
branch
2 times, most recently
from
e3d4271 to
072342c
Compare
|
Fixed the window sizing issue of the second case. It's not perfect (the string needs to have manual line breaks and it might not behave well with large text sizes) but the window sizing system is not good to work with.
Also, the warning shows when setting the password for a server, which is silly. ("You, the server owner, may be able to see what you enter here!") Is it worth bothering to not show it in this case? |
Unless it is super complicated I'd say yes. Security warnings that are made too often just lead to people ignoring them every time. |
nielsmh
force-pushed
the
password-warning
branch
from
072342c to
6e0e5de
Compare
|
No warning: Warning, automatically line broken: |
| assert(this->nested_root->smallest_x > 0); | ||
| this->warning_size.width = this->nested_root->current_x - (WD_FRAMETEXT_LEFT + WD_FRAMETEXT_RIGHT + WD_FRAMERECT_LEFT + WD_FRAMERECT_RIGHT); | ||
| this->warning_size.height = GetStringHeight(STR_WARNING_PASSWORD_SECURITY, this->warning_size.width); | ||
| this->warning_size.height += WD_FRAMETEXT_TOP + WD_FRAMETEXT_BOTTOM + WD_FRAMERECT_TOP + WD_FRAMERECT_BOTTOM; |
There was a problem hiding this comment.
Is it useful if we put this "algorithm" in a function? You now use it at two places, but if I understand it correctly, it can also be useful for other places where we want this kind of behaviour? (honest question btw, no is a valid answer :D)
There was a problem hiding this comment.
I think the best would be to add a flag to label controls or similar, that they have height dependent on width (and width is not measured for the widget), which then causes them to wrap and size after the main size calculations are done.
Add a warning text to password entry windows, to remind players that the protocol is not truly secure.
Currently has an issue with sizing/spacing in the more generic text entry window, without the "Default password" button:
