Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riot-{web,desktop}: 1.0.{6,4} -> 1.0.7 #59604

Merged
merged 2 commits into from Apr 15, 2019
Merged

riot-{web,desktop}: 1.0.{6,4} -> 1.0.7 #59604

merged 2 commits into from Apr 15, 2019

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Apr 15, 2019

Motivation for this change

This updates riot-web and riot-desktop to the latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

CC riot-web package maintainer: @bachp

@bachp
Copy link
Member

bachp commented Apr 15, 2019

Why can't we use the same sources for both?

bachp
bachp approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@bachp bachp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

riot-web works fine

@pacien
Copy link
Contributor Author

pacien commented Apr 15, 2019

@bachp wrote:

Why can't we use the same sources for both?

The riot-web package is currently based on a prebuilt tarball whereas the riot-desktop package needs source files that are not present in that tarball.

We could build riot-web from source as well but its build process is quite messy (see #57838 (comment)).

@bachp
Copy link
Member

bachp commented Apr 15, 2019

@pacien Ok got it. I think I heared that before. Thank you for doing the update.

worldofpeace
worldofpeace approved these changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

riot-desktop works for me.

@worldofpeace worldofpeace merged commit c799751 into NixOS:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bachp bachp bachp approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pacien @bachp @worldofpeace @GrahamcOfBorg