Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyschedule: init at 0.2.34 #59541

Merged
merged 1 commit into from Apr 15, 2019
Merged

pythonPackages.pyschedule: init at 0.2.34 #59541

merged 1 commit into from Apr 15, 2019

Conversation

costrouc
Copy link
Member

closes PR #37371. That PR was inactive

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc costrouc requested a review from FRidh as a code owner April 15, 2019 00:21
@worldofpeace
Copy link
Contributor

Builds for all interpreters, but I didn't see any tests being ran in the output.
None in the tarball either.

@costrouc
Copy link
Member Author

@worldofpeace just checked and added a note that the tests are not included with the release. https://github.com/timnon/pyschedule/tree/master/examples

@costrouc
Copy link
Member Author

@GrahamcOfBorg build python2Packages.pyschedule python3Packages.pyschedule

@worldofpeace
Copy link
Contributor

@worldofpeace just checked and added a note that the tests are not included with the release. https://github.com/timnon/pyschedule/tree/master/examples

Thanks. It's also a good idea to try to convince the author to distribute tests because they're useful to many distros.

@worldofpeace worldofpeace merged commit afdec90 into NixOS:master Apr 15, 2019
@costrouc
Copy link
Member Author

On that note. Yes I've run into this many times. I'll have to have a message that I can paste as an issue for the project when I run into this.

@worldofpeace
Copy link
Contributor

On that note. Yes I've run into this many times. I'll have to have a message that I can paste as an issue for the project when I run into this.

Exactly, pretty much an explanation we can all agree on.
This looks paste-able from dotlambda

Web search for reference

I also like to mention that Debian requires using the source tarball, and prefers having tests to verify the package was installed successfully. Gentoo also has dedicated test phase for this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@costrouc @worldofpeace @GrahamcOfBorg