Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(backport) nixos/manual: update 17.03 -> 19.03 in upgrading section #59365

Merged
merged 1 commit into from Apr 12, 2019
Merged

(backport) nixos/manual: update 17.03 -> 19.03 in upgrading section #59365

merged 1 commit into from Apr 12, 2019

Conversation

mogorman
Copy link
Contributor

nixos/manual: update 17.03 -> 19.03 in upgrading section

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mogorman
Copy link
Contributor Author

@grahamc backported pr for excellence.

@grahamc
Copy link
Member

grahamc commented Apr 12, 2019

Oops, I should have clarified -- can you backport da035d3 specifically?

@mogorman
Copy link
Contributor Author

no my bad, i havent done a backport for nixos yet and picked wrong hash. fixed now

@grahamc grahamc changed the title Merge pull request #59349 from mogorman/manual-upgrading (backport) nixos/manual: update 17.03 -> 19.03 in upgrading section Apr 12, 2019
@grahamc
Copy link
Member

grahamc commented Apr 12, 2019

Thank you!

@grahamc grahamc merged commit aa3e6bf into NixOS:release-19.03 Apr 12, 2019
@mogorman mogorman deleted the upgrading_manual branch April 12, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mogorman @grahamc @GrahamcOfBorg