Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python.pkgs.{tensorflow-probability,dm-sonnet,graph_nets}: init #59363

Merged
merged 3 commits into from Apr 13, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Apr 12, 2019

Motivation for this change

I want to work with graph networks in tensorflow. The canonical library depends on dm-sonnet, which in turn depends on tensorflow-probability.

The dm-sonnet build is based on the tensorflow build (though greatly simplified), since I couldn't find any documentation for bazel builds.

I tested this by building a model to predict the shortest path on graphs, as in the example.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
Copy link
Member Author

timokau commented Apr 12, 2019

@GrahamcOfBorg build python2.pkgs.graph_nets python3.pkgs.graph_nets

CC @jyp who contributed to the tensorflow package a couple of times and may or may not be interested in reviewing this :)

@timokau
Copy link
Member Author

timokau commented Apr 12, 2019

ofBorg failure:

The TensorFlow library was compiled to use AVX instructions, but these aren't available on your machine.

Seems to be an issue with the binary build of tensorflow and an older ofBorg builder. Not related to this.

@timokau timokau merged commit 05a53ec into NixOS:master Apr 13, 2019
@timokau timokau deleted the graph_nets-init branch April 13, 2019 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants