Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dmd, gtk: Remove dontStrip because with binutils 2.31 everything is working again #59390

Merged
merged 1 commit into from May 12, 2019
Merged

dmd, gtk: Remove dontStrip because with binutils 2.31 everything is working again #59390

merged 1 commit into from May 12, 2019

Conversation

ThomasMader
Copy link
Contributor

Because binutils 2.31 is merged now #40397 is fixed and the workaround (dontStrip=true) can be removed.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ThomasMader
Copy link
Contributor Author

@GrahamcOfBorg build dmd gtkd

This was referenced May 12, 2019
Closed
Merged
@c0bw3b c0bw3b self-assigned this May 12, 2019
@c0bw3b c0bw3b merged commit 2c4bc9a into NixOS:staging May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@c0bw3b c0bw3b

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ThomasMader @c0bw3b @GrahamcOfBorg