Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] gitea 1.7.6 #59392

Merged
merged 6 commits into from Apr 13, 2019
Merged

[18.09] gitea 1.7.6 #59392

merged 6 commits into from Apr 13, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Apr 13, 2019

see #59387.

From release notes:

SECURITY: Prevent remote code execution vulnerability with mirror repo URL settings

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Vskilet and others added 6 commits April 13, 2019 13:03
@Vskilet @flokli
gitea: 1.6.4 -> 1.7.0
768756a 
(cherry picked from commit f5d69f8)
@etu @flokli
gitea: 1.7.0 -> 1.7.1
1e1dab0 
Changelog: https://github.com/go-gitea/gitea/releases/tag/v1.7.1
(cherry picked from commit ae0c47b)
@delroth @flokli
nixos/tests/gitea: fix eval warnings
4224ef9 
trace: warning: config.services.gitea.database.password will be stored as plaintext
        in the Nix store. Use database.passwordFile instead.

(Arguably, this shouldn't be a warning at all. But making it happy is
easier than having a debate on the value of this warning.)

(cherry picked from commit c0829a0)
@flokli
gitea: 1.7.1 -> 1.7.3
20590e2 
(cherry picked from commit 1246a73)
@etu @flokli
gitea: 1.7.3 -> 1.7.5
b43d1d8 
Changelogs:
https://github.com/go-gitea/gitea/releases/tag/v1.7.5
https://github.com/go-gitea/gitea/releases/tag/v1.7.4
(cherry picked from commit c94d027)
@flokli
gitea: 1.7.5 -> 1.7.6
c06c93b 
From [release notes](https://github.com/go-gitea/gitea/releases/tag/v1.7.6):

SECURITY: Prevent remote code execution vulnerability with mirror repo URL settings
(cherry picked from commit 7578ec4)
@flokli flokli requested a review from andir April 13, 2019 11:13
@flokli
Copy link
Contributor Author

flokli commented Apr 13, 2019

@GrahamcOfBorg test gitea

@flokli
Copy link
Contributor Author

flokli commented Apr 13, 2019

aarch64-linux tests passed on ofborg, the x86_64-linux locally. Merging.

@flokli flokli merged commit 47bc2fa into NixOS:release-18.09 Apr 13, 2019
@flokli flokli deleted the 18.09/gitea-1.7.6 branch April 13, 2019 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
1.severity: security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@flokli @Vskilet @etu @delroth