replace deprecated usage of PermissionsStartOnly (part 1) #59389
Conversation
|
@GrahamcOfBorg test clickhouse codicmd etcd ipfs |
|
Going through the draft PR, there was some discussion about clickhouse (which had a static data directory anyway) and mpd (with some discussion about the We didn't receive any feedback on the changes proposed to the following services/modules:
Given these are pretty mechanical, and this is unstable, I tend to merge it anyway - it's very granular commits, and we can revert them individually in case of any problems. @infinisil, what do you think? |
|
I think we should double-check these services, but in general I'm fine with merging this soon, the chance of this causing breakage shouldn't be high and the change is quite nice. Considering that |
|
@infinisil I did review the services, and they LGTM.
|
|
🚀 |
The default for logFile is /var/log/couchdb.log, and the tmpfile rules chown
${dirOf cfg.logFile}, which is just /var/log, to couchdb:couchdb.
This was found by Edes' report on IRC, which looked like
Detected unsafe path transition /var/log → /var/log/journal during canonicalization of /var/log/journal
While this bug has been present since the initial couchdb module in
62438c0 by @garbas, this wasn't a
problem, because the initial module only created and chowned /var/log
if it didn't exist yet, which can't occur because this gets created in
the initial phases of NixOS startup.
However with the recent move from manual preStart chown scripts to
systemd.tmpfiles.rules in 062efe0 (NixOS#59389),
this chown is suddenly running unconditionally at every system
activation, therefore triggering the above error.
|
@volth That is unfortunate. Sorry for the inconvenience. Given what you said I believe the fix should be to add an additional entry to If you would be willing to test that would be appreciated. |
Motivation for this change
First round of code ready for merging from #56265
ping @flokli
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)