Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/deepin-menu: init #59433

Merged
merged 1 commit into from Apr 14, 2019
Merged

nixos/deepin-menu: init #59433

merged 1 commit into from Apr 14, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Apr 14, 2019

Motivation for this change

Add NixOS module for the deepin-menu dbus service.

About packaging deepin for NixOS: #59023

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo romildo requested a review from infinisil as a code owner April 14, 2019 02:52
worldofpeace
worldofpeace approved these changes Apr 14, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct.

Haven't tested it, but I don't think that would be needed in this case.

@romildo
Copy link
Contributor Author

romildo commented Apr 14, 2019 •
edited

I have tested it with deepin-terminal in a VM.

@worldofpeace worldofpeace merged commit c9a925d into NixOS:master Apr 14, 2019
@romildo
Copy link
Contributor Author

romildo commented Apr 14, 2019

@worldofpeace thank you.

@romildo romildo deleted the upd.deepin.deepin-menu branch April 14, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romildo @worldofpeace @GrahamcOfBorg