Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyomo: init at 5.6.5 #59545

Merged
merged 2 commits into from Apr 24, 2019
Merged

pythonPackages.pyomo: init at 5.6.5 #59545

merged 2 commits into from Apr 24, 2019

Conversation

costrouc
Copy link
Member

Closes #37372. PR was not being fixed.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc costrouc requested a review from FRidh as a code owner April 15, 2019 01:30
@costrouc costrouc changed the title Python pyomo init pythonPackages.pyomo: init at 5.6.5 Apr 15, 2019
@costrouc
Copy link
Member Author

@GrahamcOfBorg build python2Packages.pyomo python3Packages.pyomo

@Lassulus
Copy link
Member

I will merge this tomorrow as #37372 is no longer up2date.

@Lassulus Lassulus merged commit e5830ba into NixOS:master Apr 24, 2019
dotlambda
dotlambda reviewed Apr 24, 2019
View reviewed changes
pkgs/development/python-modules/pyomo/default.nix
'';

meta = with lib; {
description = "Pyomo: Python Optimization Modeling Objects";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package name should not be included in the description: https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks like it was already merged. I can still make the quick fix if needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed, but please adhere to the contributing guidelines next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@costrouc @Lassulus @dotlambda @GrahamcOfBorg