New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gettext: fix stdenv-darwin; remove Bison dependency #59553
Conversation
Commit 1279016 broke building nixpkgs.clangStdenv (stdenv-darwin) on macOS: nix-build -A clangStdenv . these derivations will be built: /nix/store/b3vyrfzarzyh51n7fj9wrpw12sq3765l-stdenv-darwin.drv building '/nix/store/b3vyrfzarzyh51n7fj9wrpw12sq3765l-stdenv-darwin.drv'... output '/nix/store/3agkxvkbhfpimnx5imr09q4rq9pxmjda-stdenv-darwin' is not allowed to refer to the following paths: /nix/store/jnzhx3hni0ds1wf49z8wfnxi3qdnkk6q-gnum4-1.4.18 /nix/store/smdncnz5pkl5q39k4ldk8bh84p2hmj19-bison-3.3.2 error: build of '/nix/store/b3vyrfzarzyh51n7fj9wrpw12sq3765l-stdenv-darwin.drv' failed Remove gettext's build dependency on Bison to avoid this error, fixing Nixpkgs on macOS. To avoid rebuilding everything unnecessarily on Linux, only apply these changes to macOS and keep the Bison dependency for Linux.
@strager Thank you! |
Commit 1279016 broke building nixpkgs.clangStdenv (stdenv-darwin) on macOS: nix-build -A clangStdenv . these derivations will be built: /nix/store/b3vyrfzarzyh51n7fj9wrpw12sq3765l-stdenv-darwin.drv building '/nix/store/b3vyrfzarzyh51n7fj9wrpw12sq3765l-stdenv-darwin.drv'... output '/nix/store/3agkxvkbhfpimnx5imr09q4rq9pxmjda-stdenv-darwin' is not allowed to refer to the following paths: /nix/store/jnzhx3hni0ds1wf49z8wfnxi3qdnkk6q-gnum4-1.4.18 /nix/store/smdncnz5pkl5q39k4ldk8bh84p2hmj19-bison-3.3.2 error: build of '/nix/store/b3vyrfzarzyh51n7fj9wrpw12sq3765l-stdenv-darwin.drv' failed Remove gettext's build dependency on Bison to avoid this error, fixing Nixpkgs on macOS. To avoid rebuilding everything unnecessarily on Linux, only apply these changes to macOS and keep the Bison dependency for Linux. (cherry picked from commit 6ccf220) cc #59553 #59525
This pull request has been mentioned on Nix community. There might be relevant details there: |
This broke the cross build, because the |
The problem is actually that |
Motivation for this change
Commit 1279016 broke building nixpkgs.clangStdenv (stdenv-darwin) on macOS:
Remove gettext's build dependency on Bison to avoid this error, fixing Nixpkgs on macOS. This fixes issue #59450.
To avoid rebuilding everything unnecessarily on Linux, only apply these changes to macOS and keep the Bison dependency for Linux.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)