Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dune: 1.9.0 -> 1.9.1 #59606

Merged
merged 1 commit into from Apr 16, 2019
Merged

dune: 1.9.0 -> 1.9.1 #59606

merged 1 commit into from Apr 16, 2019

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Apr 15, 2019

Motivation for this change

Bug fix release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@basvandijk
Copy link
Member

@GrahamcOfBorg build dune ocamlPackages.conduit

@basvandijk
Copy link
Member

basvandijk commented Apr 15, 2019

The build failure on darwin is due to python3 failing to build. This should be fixed by fdbcf5b. Could you rebase on the latest master so that we can check if the build on darwin succeeds?

@vbgl
Copy link
Contributor Author

vbgl commented Apr 16, 2019

@GrahamcOfBorg build dune ocamlPackages.conduit

@basvandijk basvandijk merged commit ced565b into NixOS:master Apr 16, 2019
@vbgl vbgl deleted the dune-1.9.1 branch April 16, 2019 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants