lumo 1.9.0 -> 1.10.1 plus darwin support #59414

hlolli · 2019-04-13T18:14:35Z

Motivation for this change

New release, also some requests for adding darwin support which I implemented by adding two missing buildDependencies.

Things done

Removed and added some npm packages, rebuilt the node10 packages files. Tested in on my linux and on MacOs Sierra in VirtualBox.

[ x ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- [ x ] NixOS
- [ x ] macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ x ] Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Assured whether relevant documentation is up to date
Fits CONTRIBUTING.md.

hlolli · 2019-08-29T23:37:17Z

rebased and merge conflict resolved. Can this be merged @markuskowa ?

Mic92 · 2020-02-07T16:19:34Z

I will have a look, once it gets updated.

raboof · 2020-02-11T15:42:40Z

I ran into #79781 and can confirm that when using lumo from this branch it does work.

Seems like this PR needs a rebase, though?

hlolli · 2020-02-11T17:23:09Z

Because of not being rebased, it will work. I'm finishing work now. I think pkgs.clojure needs a patch or older version provided. Will update in ~2 hours.

hlolli · 2020-02-11T18:53:26Z

the branch is rebased now, but and the bug is there. Will try few things out, starting with simplest solutions.

hlolli · 2020-02-11T19:31:09Z

The problem seems to be purely due to clojure, adding this check to interpreters/clojure/default.nix

doInstallCheck = true;
  installCheckPhase = ''
   CLJ_CONFIG=`pwd` CLJ_CACHE=$tmp $out/bin/clojure -Spath
  '';

causes

Error building classpath. Failed to read artifact descriptor for org.clojure:clojure:jar:1.10.1
org.eclipse.aether.resolution.ArtifactDescriptorException: Failed to read artifact descriptor for org.clojure:clojure:jar:1.10.1

I think the best way to solve it is by providing the clojure binary an environment where it has access to all its runtime jar deps. This is easy to do, and they do provide deps.edn which clojure reads from on each invocation.

hlolli · 2020-02-11T22:30:11Z

after #79868 gets merged, Lumo should work fine, with or without this bump (tough I'd love to see this merged since it's been stale for almost a year).

Mic92 · 2020-02-12T07:03:09Z

pkgs/development/node-packages/node-env.nix

@@ -363,7 +354,7 @@ let

        npm ${forceOfflineFlag} --nodedir=${nodeSources} ${npmFlags} ${stdenv.lib.optionalString production "--production"} rebuild

-        if [ "''${dontNpmInstall-}" != "1" ]
+        if [ "$dontNpmInstall" != "1" ]


This should stay!

I have no recollection from this change. Most likely the generated data from 1.6.1. You mean this should stay, the change or the original? (I assume the original, in which case regenerating with right version should fix it).

It is a bug in node2nix itself: svanderburg/node2nix#174

We need to keep the current line.

Mic92 · 2020-02-12T07:05:18Z

pkgs/development/node-packages/composition-v10.nix

@@ -1,4 +1,4 @@
-# This file has been generated by node2nix 1.7.0. Do not edit!
+# This file has been generated by node2nix 1.6.1. Do not edit!


It is weird that this was now regenerated using an older version of node2nix. Did you generated it from an up-to-date nixpkgs repository?

ah, yes I have older version managed by npm -g, I should ofc install it via nix (but there were some bugs fixed upstream that I needed for something sometime).

Will fix after work

hlolli · 2020-02-19T22:58:40Z

@Mic92 I finally got around fixing the comments, the build was also failing, for the same reason the current Lumo build is failing. So I added 2 extra patches and the build goes trough. It would be nice if this could ship with the next release, because as far as I see, Lumo would otherwise get a broken status. I guess for that I'd need to change base?

raboof · 2020-02-20T09:41:49Z

branch is still working for me 😄 👍

GrahamcOfBorg added 6.topic: darwin 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Apr 13, 2019

markuskowa added the 8.has: package (update) label Apr 13, 2019

hlolli force-pushed the lumo-bump branch from b9b287c to e7b8bdd Compare August 29, 2019 22:40

ofborg bot added the 2.status: merge conflict label Aug 29, 2019

hlolli force-pushed the lumo-bump branch from e7b8bdd to 61eca87 Compare August 29, 2019 23:18

ofborg bot removed the 2.status: merge conflict label Aug 29, 2019

matthewbauer requested review from adisbladis, NeQuissimus and svanderburg and removed request for adisbladis and NeQuissimus September 6, 2019 15:57

anmonteiro mentioned this pull request Dec 10, 2019

Lumo 1.10.1 doesn't run in NixOS 19.09 anmonteiro/lumo#492

Open

hlolli mentioned this pull request Feb 7, 2020

nodePackages: update set #79410

Merged

10 tasks

hlolli mentioned this pull request Feb 11, 2020

Failed to install lumo because of repo1.maven.org: Name or service not known #79781

Closed

veprbl added the 2.status: merge conflict label Feb 11, 2020

hlolli force-pushed the lumo-bump branch from 61eca87 to 4e24ade Compare February 11, 2020 18:52

ofborg bot added 10.rebuild-darwin: 11-100 and removed 2.status: merge conflict labels Feb 11, 2020

ofborg bot removed the 10.rebuild-darwin: 1-10 label Feb 11, 2020

Mic92 reviewed Feb 12, 2020

View reviewed changes

NeQuissimus removed their request for review February 12, 2020 13:11

hlolli force-pushed the lumo-bump branch from 4e24ade to 84ad6f7 Compare February 19, 2020 20:37

ofborg bot added the 2.status: merge conflict label Feb 19, 2020

hlolli force-pushed the lumo-bump branch from 84ad6f7 to 131a01e Compare February 19, 2020 21:40

lumo 1.9.0 -> 1.10.1 plus darwin support

ef712ff

hlolli force-pushed the lumo-bump branch from 131a01e to ef712ff Compare February 19, 2020 22:17

ofborg bot removed the 2.status: merge conflict label Feb 19, 2020

cleanup

ad56672

ofborg bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 11-100 labels Feb 19, 2020

Mic92 merged commit c385f9f into NixOS:master Feb 20, 2020

hlolli deleted the lumo-bump branch February 20, 2020 11:49

hlolli mentioned this pull request Feb 20, 2020

ZERO Hydra Failures 20.03 #80379

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lumo 1.9.0 -> 1.10.1 plus darwin support #59414

lumo 1.9.0 -> 1.10.1 plus darwin support #59414

hlolli commented Apr 13, 2019

hlolli commented Aug 29, 2019

Mic92 commented Feb 7, 2020

raboof commented Feb 11, 2020

hlolli commented Feb 11, 2020

hlolli commented Feb 11, 2020

hlolli commented Feb 11, 2020

hlolli commented Feb 11, 2020

Mic92 Feb 12, 2020

hlolli Feb 12, 2020

Mic92 Feb 12, 2020

Mic92 Feb 12, 2020

Mic92 Feb 12, 2020

hlolli Feb 12, 2020

hlolli commented Feb 19, 2020

raboof commented Feb 20, 2020

		@@ -1,4 +1,4 @@
		# This file has been generated by node2nix 1.7.0. Do not edit!
		# This file has been generated by node2nix 1.6.1. Do not edit!

lumo 1.9.0 -> 1.10.1 plus darwin support #59414

lumo 1.9.0 -> 1.10.1 plus darwin support #59414

Conversation

hlolli commented Apr 13, 2019

Motivation for this change

Things done

hlolli commented Aug 29, 2019

Mic92 commented Feb 7, 2020

raboof commented Feb 11, 2020

hlolli commented Feb 11, 2020

hlolli commented Feb 11, 2020

hlolli commented Feb 11, 2020

hlolli commented Feb 11, 2020

Mic92 Feb 12, 2020

Choose a reason for hiding this comment

hlolli Feb 12, 2020

Choose a reason for hiding this comment

Mic92 Feb 12, 2020

Choose a reason for hiding this comment

Mic92 Feb 12, 2020

Choose a reason for hiding this comment

Mic92 Feb 12, 2020

Choose a reason for hiding this comment

hlolli Feb 12, 2020

Choose a reason for hiding this comment

hlolli commented Feb 19, 2020

raboof commented Feb 20, 2020