Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hexyl: 0.4.0 -> 0.5.0 #59413

Merged
merged 1 commit into from Apr 13, 2019
Merged

hexyl: 0.4.0 -> 0.5.0 #59413

merged 1 commit into from Apr 13, 2019

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Apr 13, 2019 •
edited

changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @lilyball

@markuskowa markuskowa merged commit 8a0b271 into NixOS:master Apr 13, 2019
@dywedir dywedir deleted the hexyl branch April 13, 2019 20:28
@lilyball
Copy link
Member

This builds just fine on Darwin.

I don't understand why ofBorg failed to build this on Darwin. Checking the log I see

mkdir: cannot create directory '/nix/store/c5bf6pj9hhf0n5yn8i3h7fg87n8rwcay-curl-7.64.0-man/share/man/man1': File exists
make[4]: *** [Makefile:552: install-man1] Error 1
make[4]: Leaving directory '/private/tmp/nix-build-curl-7.64.0.drv-0/curl-7.64.0/docs'
make[3]: *** [Makefile:765: install-am] Error 2
make[3]: Leaving directory '/private/tmp/nix-build-curl-7.64.0.drv-0/curl-7.64.0/docs'
make[2]: *** [Makefile:601: install-recursive] Error 1
make[2]: Leaving directory '/private/tmp/nix-build-curl-7.64.0.drv-0/curl-7.64.0/docs'
make[1]: *** [Makefile:1958: install-recursive] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-curl-7.64.0.drv-0/curl-7.64.0/src'
make: *** [Makefile:920: install-recursive] Error 1
builder for '/nix/store/r0hxp7cyqaf4p48l1k1784hfpv7ccy8k-curl-7.64.0.drv' failed with exit code 2

ofBorg has had issues with Rust packages in the past due to sandboxing but it was a different error. This one, where it can't install a curl manpage because the file already exists, is mysterious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dywedir @lilyball @GrahamcOfBorg @markuskowa