Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purescript: upgrade to 0.12.5 #59589

Merged
merged 2 commits into from Apr 25, 2019
Merged

purescript: upgrade to 0.12.5 #59589

merged 2 commits into from Apr 25, 2019

Conversation

justinwoo
Copy link
Member

@justinwoo justinwoo commented Apr 15, 2019

https://github.com/purescript/purescript/releases/v0.12.5

mirrors changes in justinwoo/easy-purescript-nix@87c49e2

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@justinwoo
Copy link
Member Author

@GrahamcOfBorg build purescript

@justinwoo
Copy link
Member Author

^ assuming this doesn't work for non privileged users

@grahamc
Copy link
Member

grahamc commented Apr 15, 2019

@GrahamcOfBorg eval
@GrahamcOfBorg build purescript

also, please edit your commit message to be "purescript: oldversion -> newversion" :) Thanks!

+ version must start with a number
@c0bw3b
Copy link
Contributor

c0bw3b commented Apr 25, 2019

@justinwoo I change the package name to keep it consistent with the one in all-packages.nix
Also adapted the version number to Nix preference.

@GrahamcOfBorg build purescript

@c0bw3b c0bw3b merged commit b1e23ab into NixOS:master Apr 25, 2019
@justinwoo justinwoo mentioned this pull request Jun 3, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants