Run mypy on the manifest code. #16346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Next up: checking if this actually runs in CI now |
gsnedders
reviewed
Apr 15, 2019
gsnedders
force-pushed
the
mypy-manifest
branch
from
3102483
to
e6d9518
Compare
gsnedders
force-pushed
the
mypy-manifest
branch
from
e6d9518
to
29f9062
Compare
foolip
added a commit
that referenced
this pull request
May 17, 2021
This is faster locally when running mypy over and over, and shouldn't matter in CI where there is no cache. The flag has been around ever since mypy was introduced: #16346 Mypy documentation of this flag: https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-no-incremental
foolip
added a commit
that referenced
this pull request
May 18, 2021
This is faster locally when running mypy over and over, and shouldn't matter in CI where there is no cache. The flag has been around ever since mypy was introduced: #16346 Mypy documentation of this flag: https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-no-incremental
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 20, 2021
…incremental flag), a=testonly Automatic update from web-platform-tests Enable mypy incremental mode (drop --no-incremental flag) (#29019) This is faster locally when running mypy over and over, and shouldn't matter in CI where there is no cache. The flag has been around ever since mypy was introduced: web-platform-tests/wpt#16346 Mypy documentation of this flag: https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-no-incremental -- wpt-commits: ffa4a71ed989ac3538b0bb44e632888e2b263d12 wpt-pr: 29019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.