Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

musl: 1.1.21 -> 1.1.22 #59417

Merged
merged 1 commit into from Apr 17, 2019
Merged

musl: 1.1.21 -> 1.1.22 #59417

merged 1 commit into from Apr 17, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 13, 2019

https://www.openwall.com/lists/musl/2019/04/10/1

Motivation for this change

cc @nh2 and folks following previous musl+nixpkgs updates:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill merged commit 31726fd into NixOS:master Apr 17, 2019
@dtzWill dtzWill deleted the update/musl-1.1.22 branch April 17, 2019 19:06
@matthewbauer
Copy link
Member

I'm getting this error from the update:

/nix/store/rw0x0lq40ai06v9sqnm4z59qm140ayac-x86_64-unknown-linux-musl-binutils-2.31.1/bin/x86_64-unknown-linux-musl-ld:INSTALL: file format not recognized; treating as linker script
/nix/store/rw0x0lq40ai06v9sqnm4z59qm140ayac-x86_64-unknown-linux-musl-binutils-2.31.1/bin/x86_64-unknown-linux-musl-ld:INSTALL:2: syntax error
collect2: error: ld returned 1 exit status

This is from:

$ nix build -f '<nixpkgs>' pkgsStatic.busybox

@dtzWill
Copy link
Member Author

dtzWill commented May 1, 2019

This seems awfully similar to: #52074 which was before this last update? Does reverting to 1.1.21 fix this for you, just to be sure/clear?

@dtzWill
Copy link
Member Author

dtzWill commented May 1, 2019

If you just want something for nix, consider using pkgsMusl.busybox-sandbox-shell which is statically linked and doesn't use the hacks that cause this (which hopefully we can remove regardless :)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @matthewbauer @GrahamcOfBorg @markuskowa