Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplenote: 1.1.3 -> 1.5.0 #59418

Closed
wants to merge 2 commits into from
Closed

simplenote: 1.1.3 -> 1.5.0 #59418

wants to merge 2 commits into from

Conversation

tinybeachthor
Copy link
Contributor

@tinybeachthor tinybeachthor commented Apr 13, 2019 •
edited

Motivation for this change

Old version was opening a pop-up, offering an upgrade on each open.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member

dtzWill commented Apr 17, 2019 

error: while evaluating 'callPackageWith' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-2-shlevy.ewr1.nix.ci/lib/customisation.nix:108:35, called from /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-2-shlevy.ewr1.nix.ci/pkgs/top-level/all-packages.nix:23593:16:
while evaluating 'makeOverridable' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-2-shlevy.ewr1.nix.ci/lib/customisation.nix:67:24, called from /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-2-shlevy.ewr1.nix.ci/lib/customisation.nix:112:8:
anonymous function at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-2-shlevy.ewr1.nix.ci/pkgs/applications/misc/simplenote/default.nix:1:1 called without required argument 'at_spi2_atk', at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-2-shlevy.ewr1.nix.ci/lib/customisation.nix:69:12

Looks like this uses an alias instead of the "actual" attribute name for at_spi2_atk?

@tinybeachthor tinybeachthor force-pushed the upgrade-simplenote-1.5.0 branch 2 times, most recently from 4db3428 to 1faf600 Compare April 20, 2019 13:38
@tinybeachthor
Copy link
Contributor Author

I am quite lost, no idea why it's failing.
I have added the at_spi2_atk dependancy in the same way as it was added here: #33062

If I compile it on my computer it builds it and works fine.

@dtzWill
Copy link
Member

dtzWill commented Apr 24, 2019

That PR is from 2017 hehe 😁.

Quick grep suggests the hyphenated form is the standard these days (at-spi2-atk).

@aanderse
Copy link
Member

@GrahamcOfBorg build simplenote

aanderse
aanderse approved these changes May 12, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look reasonable. Builds and runs for me locally. LGTM 👍
@dtzWill are you OK with this one?

@mmahut
Copy link
Member

mmahut commented Aug 12, 2019

@WhoMeNope do you mind rebasing this?

@Kiwi Kiwi mentioned this pull request Sep 22, 2019
Merged
10 tasks
@peterhoeg
Copy link
Member

Superseded by #69266

@peterhoeg peterhoeg closed this Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@tinybeachthor @dtzWill @aanderse @mmahut @peterhoeg @markuskowa @Janik-Haag