Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mdbook: fix Darwin support #59385

Merged
merged 1 commit into from Apr 17, 2019
Merged

mdbook: fix Darwin support #59385

merged 1 commit into from Apr 17, 2019

Conversation

lilyball
Copy link
Member

@lilyball lilyball commented Apr 13, 2019 •
edited

Motivation for this change

This restores Darwin compatibility. The build is impure now as it links against system CoreFoundation, but we have no alternative.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @Havvy

@Havvy
Copy link
Contributor

Havvy commented Apr 13, 2019

I'm unable to review this since I don't have the OS in question. But I see nothing obviously wrong to me.

@lilyball
Copy link
Member Author

PR updated to use darwin.cf-private. I'll do this for watchexec in a separate PR.

@lilyball
Copy link
Member Author

watchexec PR: #59428

@veprbl
Copy link
Member

veprbl commented Apr 13, 2019

@GrahamcOfBorg build mdbook

1 similar comment
@veprbl
Copy link
Member

veprbl commented Apr 15, 2019

@GrahamcOfBorg build mdbook

@veprbl veprbl merged commit e50f79a into NixOS:master Apr 17, 2019
@lilyball lilyball deleted the mdbook_darwin branch April 17, 2019 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lilyball @Havvy @veprbl @matthewbauer @GrahamcOfBorg