Revert "gettext: apply patch for CVE 2018-18751 (backport 18.09)" #59525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamcOfBorg
requested review from
andir,
vrthra,
zimbatm,
edolstra,
7c6f434c and
lovek323
veprbl
pushed a commit
that referenced
this pull request
Apr 15, 2019
Commit 1279016 broke building nixpkgs.clangStdenv (stdenv-darwin) on macOS: nix-build -A clangStdenv . these derivations will be built: /nix/store/b3vyrfzarzyh51n7fj9wrpw12sq3765l-stdenv-darwin.drv building '/nix/store/b3vyrfzarzyh51n7fj9wrpw12sq3765l-stdenv-darwin.drv'... output '/nix/store/3agkxvkbhfpimnx5imr09q4rq9pxmjda-stdenv-darwin' is not allowed to refer to the following paths: /nix/store/jnzhx3hni0ds1wf49z8wfnxi3qdnkk6q-gnum4-1.4.18 /nix/store/smdncnz5pkl5q39k4ldk8bh84p2hmj19-bison-3.3.2 error: build of '/nix/store/b3vyrfzarzyh51n7fj9wrpw12sq3765l-stdenv-darwin.drv' failed Remove gettext's build dependency on Bison to avoid this error, fixing Nixpkgs on macOS. To avoid rebuilding everything unnecessarily on Linux, only apply these changes to macOS and keep the Bison dependency for Linux. (cherry picked from commit 6ccf220) cc #59553 #59525
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #59000 to prevent breaking darwin stdenv