Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

torcs: add musicplayer.patch #59527

Closed
wants to merge 1 commit into from
Closed

torcs: add musicplayer.patch #59527

wants to merge 1 commit into from

Conversation

astro
Copy link
Contributor

@astro astro commented Apr 14, 2019 •
edited

Unbreaks build of torcs.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@astro
torcs: add musicplayer.patch
ec3c7c7 
Allows build of torcs.
@aanderse
Copy link
Member

Where is this patch from? The preference is to not maintain patch files in nixpkgs like this, but fetch them from elsewhere if possible.

@astro
Copy link
Contributor Author

astro commented Apr 15, 2019

@aanderse I have written this patch myself to fix the build on NixOS. I am not aware of any other distros that have to do the same.

@joachifm
Copy link
Contributor

The original triggers "invalid conversion from char to whatever"? If so that seems like an upstream problem and not specific to the nixpkgs toolchain, or am I missing something?

@aanderse aanderse mentioned this pull request Apr 17, 2019
Merged
10 tasks
@c0bw3b
Copy link
Contributor

c0bw3b commented Apr 24, 2019

The patch is also available on Salsa:
https://salsa.debian.org/games-team/torcs/raw/32bbe77c68b4de07b28c34497f3c0ad666ee618d/debian/patches/gcc7.patch

I added it to #59316 and built it locally. I'll merge that other PR soon.

@c0bw3b c0bw3b closed this Apr 24, 2019
@astro astro deleted the torcs branch April 25, 2019 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@astro @aanderse @joachifm @c0bw3b @GrahamcOfBorg