Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Squirrel can stack overflow when GCing deep structures, leading to crash #7513

Closed
SamuXarick opened this issue Apr 14, 2019 · 11 comments · Fixed by #9040
Closed

Squirrel can stack overflow when GCing deep structures, leading to crash #7513

SamuXarick opened this issue Apr 14, 2019 · 11 comments · Fixed by #9040

Comments

@SamuXarick
Copy link
Contributor

Version of OpenTTD

1.9.1

Expected result

crash with a dump/not crash

Actual result

OpenTTD closes itself without a dump.

Steps to reproduce

Configure one NoCAB v499 to start.
Set up opcodes to 250000 to speed things up.
Start a 4096x4096 map with high number of towns and industries.
Wait for no more than 30 minutes, for a crash/poof.
@SamuXarick
Copy link
Contributor Author

debug build x64 gives me this.
2019-04-14

@SamuXarick
Copy link
Contributor Author

When trying this with monthly autosaves , it seems to be more prevalent.

@SamuXarick
Copy link
Contributor Author

Crash without autosaving:
2019-04-15
callstack.txt

@glx22
Copy link
Contributor

glx22 commented Apr 15, 2019

Seems AI creates too many and too big arrays (but expected with this map size and the number of towns and industries I guess).

@PeterN
Copy link
Member

PeterN commented Apr 15, 2019

So we need to memory limit squirrel. I started a patch but didn't get too far, perhaps I should revisit.

@nielsmh
Copy link
Contributor

nielsmh commented Apr 15, 2019

Squirrel is a bit annoying in that it doesn't allow using a stateful per-VM memory allocator. You can add some logic to the allocator functions to keep track of the total allocation size of all Squirrel VMs, but that won't help limiting each AI or GS, or detect which one is having the biggest impact.

I explored letting it use a stateful allocator (e.g. arena allocator) and it will involve touching lots of Squirrel internals.

@PeterN
Copy link
Member

PeterN commented Apr 15, 2019

As each VM is run serially, not concurrently, an allocator can be told which VM is currently running. It makes running VMs concurrently unfeasible but I think that is already the case.

@JGRennison
Copy link
Contributor

Using recursion for GC marking is problematic even if the total memory allocation is limited.
Data structures like linked lists or unbalanced trees can use up an excessive amount of stack even if their total size is quite modest.
Mark and sweep implementations usually use queues or sets rather than the stack to avoid this.

@nielsmh nielsmh mentioned this issue Apr 15, 2019
Merged
@LordAro LordAro changed the title OpenTTD closes itself with no crash dump Crash when AI allocates too much memory Apr 15, 2019
@nielsmh nielsmh changed the title Crash when AI allocates too much memory Squirrel can stack overflow when GCing deep structures, leading to crash Oct 22, 2019
@andythenorth andythenorth reopened this Oct 22, 2019
@andythenorth
Copy link
Contributor

See also #6322, which is not the same issue, but similar area.

@andythenorth andythenorth mentioned this issue Oct 22, 2019
Closed
@rubidium42
Copy link
Contributor

Attached is a bespoke AI that triggers this issue way sooner, usually in the first few days of it running instead of having to wait very long.
NoCrab.zip

@James103
Copy link
Contributor

When OpenTTD 1.11.0 stable or OpenTTD 2021-04-14 nightly crashes from running the above AI, crash.dmp is generated with a file size of 0 bytes. crash.log and crash.png are not generated.

When OpenTTD jgrpp-0.41.0 crashes from running the above AI, crash.dmp, crash.log, and crash.png are generated as usual: crash-jgrpp-0.41.0.zip

crash.log (jgrpp-0.41.0) 
*** OpenTTD Crash Report ***

Crash at: Thu Apr 15 14:43:53 2021
In game date: 0-01-04 (34, 0) (DL: 1)

Crash reason:
 Exception:  C00000FD
 Location:   0000000000448D3B
 Info 0:     0000000000000001
 Info 1:     0000000011BC1FD8
 Message:    <none>

Non-main thread (ottd:game)

OpenTTD version:
 Version:    jgrpp-0.41.0 (0)
 NewGRF ver: 1c006d64
 Bits:       64
 Endian:     little
 Dedicated:  no
 Build date: Apr 14 2021 21:22:06
 Defines:    NDEBUG WITH_BITMATH_BUILTINS WITH_OVERFLOW_BUILTINS WITH_DEMANGLE WITH_BFD0 WITH_DBGHELP TTD_ENDIAN=TTD_LITTLE_ENDIAN WITH_PNG WITH_ZLIB WITH_LIBLZMA WITH_LZO WITH_ZSTD WITH_OPENGL WITH_PERSONAL_DIR WITH_SSE WITH_ASSERT UNICODE _UNICODE WITH_UNISCRIBE _SQ64

Stack trace:
 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
 1934C488 00000000 1934C798 00000000 1934C798 00000000 11DAF8E8 00000000
 1934C730 00000000 00448D6F 00000000 00000000 00000000 00000000 00000000
 00000000 00000000 00000000 00000000 1934C338 00000000 1934C488 00000000
 1934C488 00000000 11DAF8E8 00000000 1934C420 00000000 00448D6F 00000000
 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
 1934BFB8 00000000 1934C338 00000000 1934C338 00000000 11DAF8E8 00000000
 1934C2D0 00000000 00448D6F 00000000 00000000 00000000 00000000 00000000
 00000000 00000000 00000000 00000000 1934B618 00000000 1934BFB8 00000000
 1934BFB8 00000000 11DAF8E8 00000000 1934BF50 00000000 00448D6F 00000000
 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
 1934BA08 00000000 1934B618 00000000 1934B618 00000000 11DAF8E8 00000000
 1934B5B0 00000000 00448D6F 00000000 00000000 00000000 00000000 00000000
 00000000 00000000 00000000 00000000 1934BDF8 00000000 1934BA08 00000000
 1934BA08 00000000 11DAF8E8 00000000 1934B9A0 00000000 00448D6F 00000000
 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
 1934C178 00000000 1934BDF8 00000000 1934BDF8 00000000 11DAF8E8 00000000
 1934BD90 00000000 00448D6F 00000000 00000000 00000000 00000000 00000000
 00000000 00000000 00000000 00000000 1934B4C8 00000000 1934C178 00000000
 1934C178 00000000 11DAF8E8 00000000 1934C110 00000000 00448D6F 00000000
 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
 1934BB58 00000000 1934B4C8 00000000 1934B4C8 00000000 11DAF8E8 00000000
 1934B460 00000000 00448D6F 00000000 00000000 00000000 00000000 00000000
 00000000 00000000 00000000 00000000 1934B998 00000000 1934BB58 00000000

Registers:
 RAX: 0000000000E8F7A0 RBX: 000000001934C798 RCX: 0000000017EFC580 RDX: 0000000011DAF8E8
 RSI: 000000001934C798 RDI: 0000000000000000 RBP: 0000000000000002 RSP: 0000000011BC1FE0
 R8:  0000000018E77400 R9:  0000000000F69420 R10: 0000000000000F0F R11: 0005C003E47383AF
 R12: 0000000011DAF8E8 R13: 000000001934C6C0 R14: 0000000011DAF9C0 R15: 0000000000000000
 RIP: 0000000000448D3B EFLAGS: 00010246

 Bytes at instruction pointer:
 FF 50 18 49 8B 45 38 48 8B 70 48 48 85 F6 74 29 49 8D 5D 58 48 C1 E6 04

Operating system:
 Name:     Windows
 Release:  10.0.19041 ()
 Compiler: GCC 9.3.0 "9.3-win32 20200320"

Configuration:
 Blitter:      40bpp-anim
 Graphics set: OpenGFX (7761)
 Language:     C:\Users\james\Documents\OpenTTD jgrpp\openttd-jgrpp-0.41.0-windows-win64\lang\english.lng
 Music driver: dmusic
 Music set:    Rise of the Triad OST (No Short Tracks) (1)
 Network:      no
 Sound driver: win32
 Sound set:    OpenSFX (7758)
 Video driver: win32-opengl
 Pathfinder:   YAPF YAPF YAPF

Fonts:
 Small:  sprite
 Medium: sprite
 Large:  sprite
 Mono:   sprite

Map size: 0x1000 (64 x 64)

AI Configuration (local: 0) (current: 16):
  0: Human
  1: NoCrab (v7513)

Libraries:
 LZMA:       5.2.1
 ZSTD:       1.4.8
 LZO:        2.09
 PNG:        1.5.23
 Zlib:       1.2.8

Module information:
 C:\Users\james\Documents\OpenTTD jgrpp\openttd-jgrpp-0.41.0-windows-win64\openttd.exe handle: 0000000000400000 size: 56415746 crc: B988769F date: 2021-04-15 14:43:03
 C:\WINDOWS\SYSTEM32\ntdll.dll handle: 00007ff8463f0000 size: 2024224 crc: 686071F5 date: 2021-03-17 01:47:57
 C:\WINDOWS\System32\KERNEL32.DLL handle: 00007ff845c10000 size: 764976 crc: 721FEC31 date: 2021-03-17 01:47:37
 C:\WINDOWS\System32\KERNELBASE.dll handle: 00007ff843e60000 size: 2922392 crc: E81AFBF5 date: 2021-03-17 01:47:58
 C:\WINDOWS\SYSTEM32\apphelp.dll handle: 00007ff841460000 size: 570880 crc: 0FE4DB70 date: 2021-03-17 01:47:54
 C:\WINDOWS\System32\ADVAPI32.dll handle: 00007ff845b60000 size: 689024 crc: 355A9B19 date: 2021-03-17 01:47:35
 C:\WINDOWS\System32\msvcrt.dll handle: 00007ff844da0000 size: 637360 crc: 072737D9 date: 2021-03-17 01:47:57
 C:\WINDOWS\System32\sechost.dll handle: 00007ff846310000 size: 628616 crc: 4ED65EE2 date: 2021-03-17 01:47:58
 C:\WINDOWS\System32\RPCRT4.dll handle: 00007ff845f70000 size: 1222056 crc: 44DB9CA6 date: 2021-03-17 01:47:58
 C:\WINDOWS\System32\GDI32.dll handle: 00007ff846240000 size: 161680 crc: 2A141BAA date: 2021-03-17 01:47:45
 C:\WINDOWS\System32\win32u.dll handle: 00007ff843c40000 size: 132760 crc: 40694227 date: 2021-03-17 01:47:49
 C:\WINDOWS\System32\gdi32full.dll handle: 00007ff843b30000 size: 1075864 crc: 129DC3C4 date: 2021-03-17 01:47:59
 C:\WINDOWS\System32\msvcp_win.dll handle: 00007ff844230000 size: 634760 crc: E6732639 date: 2021-03-17 01:47:56
 C:\WINDOWS\System32\ucrtbase.dll handle: 00007ff844130000 size: 1044888 crc: D3CA62A3 date: 2021-03-17 01:47:56
 C:\WINDOWS\System32\USER32.dll handle: 00007ff8460a0000 size: 1702416 crc: CCD30A7B date: 2021-03-17 01:47:49
 C:\WINDOWS\System32\IMM32.dll handle: 00007ff846280000 size: 185448 crc: 36F61BF6 date: 2021-03-17 01:47:58
 C:\WINDOWS\System32\ole32.dll handle: 00007ff845d90000 size: 1212232 crc: 0FD6B05F date: 2021-03-17 01:47:55
 C:\WINDOWS\System32\combase.dll handle: 00007ff844eb0000 size: 3507000 crc: 54E9FC3C date: 2021-03-17 01:47:56
 C:\WINDOWS\System32\SHELL32.dll handle: 00007ff845210000 size: 7639536 crc: 41DE241A date: 2021-03-17 01:48:06
 C:\WINDOWS\System32\WS2_32.dll handle: 00007ff844e40000 size: 427200 crc: 6E37A637 date: 2021-03-17 01:47:58
 C:\WINDOWS\SYSTEM32\USP10.dll handle: 00007ff8309b0000 size: 79360 crc: 9A7F7CC2 date: 2021-03-17 01:47:58
 C:\WINDOWS\SYSTEM32\OPENGL32.dll handle: 00007ff80ffa0000 size: 1064448 crc: 77B8A2FB date: 2021-03-17 01:48:48
 C:\WINDOWS\SYSTEM32\WINMM.dll handle: 00007ff835d20000 size: 147200 crc: 18D40339 date: 2021-03-17 01:47:33
 C:\WINDOWS\SYSTEM32\GLU32.dll handle: 00007ff8266f0000 size: 164352 crc: DA0CBD61 date: 2021-03-17 01:48:48
 C:\WINDOWS\SYSTEM32\CRYPTSP.dll handle: 00007ff843500000 size: 83744 crc: DDF7045E date: 2021-03-17 01:47:56
 C:\WINDOWS\system32\rsaenh.dll handle: 00007ff842c50000 size: 207608 crc: 4A244345 date: 2021-03-17 01:47:56
 C:\WINDOWS\System32\bcrypt.dll handle: 00007ff843cd0000 size: 146240 crc: 50F3C5E2 date: 2021-03-17 01:47:56
 C:\WINDOWS\SYSTEM32\CRYPTBASE.dll handle: 00007ff8434f0000 size: 34152 crc: CC386121 date: 2021-03-17 01:47:58
 C:\WINDOWS\System32\bcryptPrimitives.dll handle: 00007ff8442d0000 size: 523200 crc: 1A4DFB8D date: 2021-03-17 01:47:58
 C:\WINDOWS\SYSTEM32\windows.storage.dll handle: 00007ff841cb0000 size: 7965496 crc: C5483783 date: 2021-03-17 01:47:47
 C:\WINDOWS\SYSTEM32\Wldp.dll handle: 00007ff8435a0000 size: 173016 crc: C5218D0B date: 2021-03-17 01:47:56
 C:\WINDOWS\System32\SHCORE.dll handle: 00007ff845ec0000 size: 704008 crc: 0812F61E date: 2021-03-17 01:47:49
 C:\WINDOWS\System32\shlwapi.dll handle: 00007ff844a30000 size: 342440 crc: 5693748E date: 2021-03-17 01:48:06
 C:\WINDOWS\system32\uxtheme.dll handle: 00007ff8415f0000 size: 627712 crc: A05B5F55 date: 2021-03-17 01:48:01
 C:\WINDOWS\System32\MSCTF.dll handle: 00007ff845960000 size: 1129056 crc: 02E7319C date: 2021-03-17 01:47:58
 C:\WINDOWS\System32\OLEAUT32.dll handle: 00007ff844960000 size: 831024 crc: 8304FB12 date: 2021-03-17 01:47:56
 C:\WINDOWS\SYSTEM32\kernel.appcore.dll handle: 00007ff841ab0000 size: 60464 crc: 7039ACC9 date: 2021-03-17 01:47:48
 C:\WINDOWS\System32\clbcatq.dll handle: 00007ff845a80000 size: 672976 crc: AD4CB4A3 date: 2021-03-17 01:47:55
 C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_60daf66a00f2e0b6\nvoglv64.dll handle: 00007fffe4b60000 size: 43326872 crc: 6E6C9DBC date: 2020-10-05 20:04:00
 C:\WINDOWS\System32\SETUPAPI.dll handle: 00007ff844460000 size: 4650576 crc: F65AC9E1 date: 2021-03-17 01:48:03
 C:\WINDOWS\System32\cfgmgr32.dll handle: 00007ff844350000 size: 305272 crc: DE2280BE date: 2021-03-17 01:47:56
 C:\WINDOWS\SYSTEM32\VERSION.dll handle: 00007ff83c860000 size: 31496 crc: 546E295F date: 2021-03-17 01:48:06
 C:\WINDOWS\SYSTEM32\WTSAPI32.dll handle: 00007ff83e770000 size: 67192 crc: 7604358D date: 2021-03-17 01:47:36
 C:\WINDOWS\SYSTEM32\msasn1.dll handle: 00007ff843720000 size: 64072 crc: FDFACF86 date: 2021-03-17 01:47:56
 C:\WINDOWS\SYSTEM32\cryptnet.dll handle: 00007ff83c5d0000 size: 181248 crc: DEF7C502 date: 2021-03-17 01:47:56
 C:\WINDOWS\System32\CRYPT32.dll handle: 00007ff843d00000 size: 1425440 crc: 71673E8A date: 2021-03-17 01:47:56
 C:\WINDOWS\System32\DEVOBJ.dll handle: 00007ff8438e0000 size: 165832 crc: 9AB2CB9F date: 2021-03-17 01:47:56
 C:\WINDOWS\System32\WINTRUST.dll handle: 00007ff843c70000 size: 382720 crc: 255FF0BB date: 2021-03-17 01:47:48
 C:\WINDOWS\SYSTEM32\ntmarta.dll handle: 00007ff842880000 size: 191656 crc: B2A51DA2 date: 2021-03-17 01:47:56
 C:\WINDOWS\SYSTEM32\dxcore.dll handle: 00007ff83a280000 size: 219016 crc: 72966353 date: 2021-03-17 01:47:41
 C:\WINDOWS\SYSTEM32\dwmapi.dll handle: 00007ff8418d0000 size: 168408 crc: BE283206 date: 2021-03-17 01:47:55
 C:\WINDOWS\SYSTEM32\powrprof.dll handle: 00007ff8430e0000 size: 295464 crc: 74230007 date: 2021-03-17 01:47:56
 C:\WINDOWS\SYSTEM32\UMPDC.dll handle: 00007ff842fa0000 size: 64552 crc: B19D9CE1 date: 2021-03-17 01:47:34
 C:\WINDOWS\SYSTEM32\WINSTA.dll handle: 00007ff842b10000 size: 351200 crc: D09048B8 date: 2021-03-17 01:47:36
 C:\WINDOWS\SYSTEM32\textinputframework.dll handle: 00007ff839e90000 size: 1021144 crc: C1B80C04 date: 2021-03-17 01:47:46
 C:\WINDOWS\SYSTEM32\CoreUIComponents.dll handle: 00007ff840e90000 size: 3537520 crc: 78335519 date: 2021-03-17 01:47:45
 C:\WINDOWS\SYSTEM32\CoreMessaging.dll handle: 00007ff8411f0000 size: 986464 crc: EDF107E3 date: 2021-03-17 01:47:55
 C:\WINDOWS\SYSTEM32\wintypes.dll handle: 00007ff8407c0000 size: 1393984 crc: DE0F60F1 date: 2021-03-17 01:47:56
 C:\WINDOWS\system32\mswsock.dll handle: 00007ff843320000 size: 418416 crc: 7609CC3B date: 2021-03-17 01:47:56
 C:\WINDOWS\SYSTEM32\winmmbase.dll handle: 00007ff81e6b0000 size: 144592 crc: B331D5DD date: 2019-12-07 09:08:07
 C:\WINDOWS\SYSTEM32\MMDevAPI.DLL handle: 00007ff83ddb0000 size: 529424 crc: DFC9B2A0 date: 2021-03-17 01:47:33
 C:\WINDOWS\SYSTEM32\wdmaud.drv handle: 00007ff82f130000 size: 259584 crc: DB966BEF date: 2019-12-07 09:08:07
 C:\WINDOWS\SYSTEM32\AVRT.dll handle: 00007ff83de70000 size: 30480 crc: D6790ED2 date: 2021-03-17 01:47:33
 C:\WINDOWS\SYSTEM32\ksuser.dll handle: 00007ff8326f0000 size: 23264 crc: A73C3DE9 date: 2019-12-07 09:08:07
 C:\WINDOWS\SYSTEM32\AUDIOSES.DLL handle: 00007ff83df00000 size: 1578512 crc: 035CD2FE date: 2021-03-17 01:47:33
 C:\WINDOWS\SYSTEM32\msacm32.drv handle: 00007ff830b10000 size: 30208 crc: 414EBD44 date: 2021-03-17 01:47:33
 C:\WINDOWS\SYSTEM32\MSACM32.dll handle: 00007ff832380000 size: 112080 crc: 7C3515A4 date: 2019-12-07 09:08:07
 C:\WINDOWS\SYSTEM32\midimap.dll handle: 00007ff830940000 size: 26624 crc: C81948B1 date: 2021-03-17 01:47:33
 C:\WINDOWS\System32\dmusic.dll handle: 00007ff826150000 size: 136192 crc: BDA2573A date: 2019-12-07 09:09:37
 C:\WINDOWS\System32\DSOUND.dll handle: 00007ff811400000 size: 615424 crc: 1C78A884 date: 2019-12-07 09:08:07
 C:\WINDOWS\System32\dmsynth.dll handle: 00007ff8256c0000 size: 126464 crc: 2A50C1AD date: 2019-12-07 09:09:37
 C:\WINDOWS\SYSTEM32\resourcepolicyclient.dll handle: 00007ff8416d0000 size: 71784 crc: 38C47F6A date: 2021-03-17 01:47:40
 C:\Windows\System32\Windows.UI.dll handle: 00007ff839f90000 size: 1317544 crc: C59FEC4F date: 2021-03-17 01:47:51
 C:\Windows\System32\WindowManagementAPI.dll handle: 00007ff83ce30000 size: 643072 crc: 4D2F7971 date: 2021-03-17 01:47:47
 C:\Windows\System32\InputHost.dll handle: 00007ff839d30000 size: 1379072 crc: 6468F174 date: 2021-03-17 01:47:46
 C:\WINDOWS\SYSTEM32\twinapi.appcore.dll handle: 00007ff83cc20000 size: 2100112 crc: 607D6B93 date: 2021-03-17 01:47:40
 C:\Windows\System32\PROPSYS.dll handle: 00007ff83f650000 size: 1009232 crc: A53AC761 date: 2021-03-17 01:47:48
 C:\WINDOWS\SYSTEM32\TextShaping.dll handle: 00007ff834ac0000 size: 707016 crc: 49A4E545 date: 2021-03-17 01:47:45
 C:\WINDOWS\System32\psapi.dll handle: 00007ff844450000 size: 19144 crc: 6E06CEEB date: 2021-03-17 01:47:54

Events: i, i

---- gamelog start ----
Tick 0: new game started
Revision text changed to jgrpp-0.41.0, savegame version 290, not modified, _openttd_newgrf_version = 0x1c006d64
New game mode: 1 landscape: 0
Added NewGRF: GRF ID 44442411, checksum E6A38D0DC67DE54DD2928447BB72F924, filename: tai_uk_houses-gamma1\tai_uk.grf (md5sum matches)
---- gamelog end ----

Recent news messages (0 of 0):

Command Log:
 Showing most recent 3 of 3 commands
   0 |    0-01-01,  0,   0 | ---m----- |        0 x       0, p1: 0x00000001, p2: 0x00000000, cc:   0, lc:   0, cmd: 0x00000043 (CmdPause)
   1 |    0-01-01,  0,   0 | ---m----- |        0 x       0, p1: 0x00FF0001, p2: 0x00000001, cc:   0, lc:   0, cmd: 0x0000005A (CmdCompanyCtrl)
   2 |    0-01-01,  0,   0 | ---m----- |        0 x       0, p1: 0x00000001, p2: 0x00000001, cc:   0, lc:   0, cmd: 0x00000043 (CmdPause)

*** End of OpenTTD Crash Report ***

Decoded stack trace:
[00] openttd              0x0000000000448D3B SQInstance::Mark(SQCollectable**) + 43 (/home/jgr/openttd/jgrpp/src/3rdparty/squirrel/squirrel/sqobject.cpp:551)
 <infinite loop>

*** End of additional info ***

Note the following:

Crash reason:
  Exception: C00000FD

Decoded stack trace:
[00] openttd              0x0000000000448D3B SQInstance::Mark(SQCollectable**) + 43 (/home/jgr/openttd/jgrpp/src/3rdparty/squirrel/squirrel/sqobject.cpp:551)
 <infinite loop>

OpenTTD/src/3rdparty/squirrel/squirrel/sqobject.cpp

Line 551 in 3e0a16c

_class->Mark(chain);

rubidium42 added a commit to rubidium42/OpenTTD that referenced this issue Apr 15, 2021
@rubidium42
Fix OpenTTD#7513: recursive garbage collection caused stack overflow
8c9a154
rubidium42 added a commit to rubidium42/OpenTTD that referenced this issue Apr 15, 2021
@rubidium42
Fix OpenTTD#7513: recursive array/class/table release caused stack ov…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
fe96738 
…erflow
rubidium42 added a commit to rubidium42/OpenTTD that referenced this issue Apr 15, 2021
@rubidium42
Fix OpenTTD#7513: recursive array/class/table release caused stack ov…
7a837ed 
…erflow
@rubidium42 rubidium42 mentioned this issue Apr 15, 2021
Merged
rubidium42 added a commit to rubidium42/OpenTTD that referenced this issue Apr 16, 2021
@rubidium42
Fix OpenTTD#7513: recursive array/class/table release caused stack ov…
1677ecb 
…erflow
rubidium42 added a commit to rubidium42/OpenTTD that referenced this issue Apr 16, 2021
@rubidium42
Fix OpenTTD#7513: recursive array/class/table release caused stack ov…
26f5c6f 
…erflow
rubidium42 added a commit to rubidium42/OpenTTD that referenced this issue Apr 16, 2021
@rubidium42
Fix OpenTTD#7513: recursive array/class/table release caused stack ov…
86eb17b 
…erflow
LordAro pushed a commit that referenced this issue Apr 17, 2021
@rubidium42 @LordAro
Fix #7513: recursive garbage collection caused stack overflow
47a99bb
LordAro pushed a commit that referenced this issue Apr 17, 2021
@rubidium42 @LordAro
Fix #7513: recursive array/class/table release caused stack overflow
44d1b96
LordAro pushed a commit to LordAro/OpenTTD that referenced this issue Apr 17, 2021
@rubidium42 @LordAro
Fix OpenTTD#7513: recursive garbage collection caused stack overflow
7a9624c
LordAro pushed a commit to LordAro/OpenTTD that referenced this issue Apr 17, 2021
@rubidium42 @LordAro
Fix OpenTTD#7513: recursive array/class/table release caused stack ov…
ce5254e 
…erflow
LordAro pushed a commit that referenced this issue Apr 18, 2021
@rubidium42 @LordAro
Fix #7513: recursive garbage collection caused stack overflow
53ce868
LordAro pushed a commit that referenced this issue Apr 18, 2021
@rubidium42 @LordAro
Fix #7513: recursive array/class/table release caused stack overflow
4f0f113
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 7513: stack overflow due to recursive GC marking and release rubidium42/OpenTTD
8 participants
@PeterN @nielsmh @andythenorth @glx22 @JGRennison @rubidium42 @James103 @SamuXarick