Codechange: replace left QSortT() with std::sort() #7509
Merged
+147
−301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Using |
|
And of course OSX still uses QSortT() |
|
Used the easy way for OSX as I can't test it myself. |
glx22
force-pushed
the
array
branch
2 times, most recently
from
8f39b88 to
081f6fa
Compare
|
several of these std::arrays feel like they could be replaced with std::vector, and the _foobar_size globals could be removed as a result Also, std::begin() & std::end() can be used on C-style arrays |
LordAro
previously requested changes
Apr 14, 2019
glx22
force-pushed
the
array
branch
3 times, most recently
from
56f4526 to
e2bf7dc
Compare
LordAro
reviewed
Apr 14, 2019
glx22
force-pushed
the
array
branch
2 times, most recently
from
d262609 to
739edaa
Compare
michicc
reviewed
Apr 18, 2019
michicc
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To sort arrays are replaced with std::array or std::vector depending on context.