Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pygal: fix build by forcing pytest_3 #59431

Closed
wants to merge 3 commits into from

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Apr 14, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle risicle requested a review from FRidh as a code owner April 14, 2019 01:09
@risicle
Copy link
Contributor Author

risicle commented Apr 14, 2019

cc @dotlambda

@dotlambda
Copy link
Member

Alternatively, we can use pytest_3. But we'll also have to overhaul WebOb's dependencies to prevent multiple versions of pytest in the closure.

Furthermore, would you mind getting rid of buildInputs in favor of nativeBuildInputs and checkInputs?

@risicle
Copy link
Contributor Author

risicle commented Apr 14, 2019

I don't really see the connection to WebOb, but I can see that WebOb appears to have pytest in its propagatedBuildInputs, which seems wrong.

@dotlambda
Copy link
Member

I don't really see the connection to WebOb

If you use pytest_3 for pygal, you'll get

Found duplicated packages in closure for dependency 'pytest':
  pytest 3.10.1 (/nix/store/b7z68j94dfmfcyl371pqr6ggdsrggwk0-python3.7-pytest-3.10.1/lib/python3.7/site-packages)
  pytest 4.2.1 (/nix/store/jky420fbml8s6b563zzfci3wicni0f5b-python3.7-pytest-4.2.1/lib/python3.7/site-packages)

which is due to WebOb.

@risicle
Copy link
Contributor Author

risicle commented Apr 14, 2019

Not if I can help it...

@risicle
Copy link
Contributor Author

risicle commented Apr 16, 2019

@dotlambda ok, I've fixed up WebOb & routes to accommodate the switch of pygal to pytest_3. I had to create a pytestrunner_pytest_3 to go with it though.

There are still downstream rebuilds that don't build, but only those that were already broken.

Noting that there are so many rebuilds, should this be targeted at staging instead of master?

@risicle risicle changed the title pythonPackages.pygal: fix build by patching setup.cfg to work with modern pytest pythonPackages.pygal: fix to work with modern pytest Apr 19, 2019
@risicle
Copy link
Contributor Author

risicle commented May 3, 2019

Added a staging rebase of this #60888

@risicle risicle changed the title pythonPackages.pygal: fix to work with modern pytest pythonPackages.pygal: fix build by forcing pytest_3 May 3, 2019
@risicle risicle closed this May 4, 2019
@FRidh
Copy link
Member

FRidh commented May 4, 2019

No need to open new PR's when rebasing.

@risicle
Copy link
Contributor Author

risicle commented May 4, 2019

It's not so much the rebase that caused it, it's that I was re-pointing it to staging rather than master. If there's a way to re-target a PR, I'd love to know.

@FRidh
Copy link
Member

FRidh commented May 4, 2019

top right next to the PR title press edit, a branch selector pops up.

@risicle
Copy link
Contributor Author

risicle commented May 4, 2019

😲 you've changed my life.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants