Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

watchexec: remove Darwin hack in favor of cf-private #59428

Merged
merged 1 commit into from Apr 17, 2019
Merged

watchexec: remove Darwin hack in favor of cf-private #59428

merged 1 commit into from Apr 17, 2019

Conversation

lilyball
Copy link
Member

Motivation for this change

This removes the hack for Darwin and just uses cf-private instead, which does effectively the same thing but in a more standardized way.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @michalrus

@lilyball lilyball mentioned this pull request Apr 13, 2019
Merged
10 tasks
@veprbl
Copy link
Member

veprbl commented Apr 13, 2019

@GrahamcOfBorg build watchexec

1 similar comment
@veprbl
Copy link
Member

veprbl commented Apr 15, 2019

@GrahamcOfBorg build watchexec

@veprbl veprbl merged commit 1ceef41 into NixOS:master Apr 17, 2019
@lilyball lilyball deleted the watchexec_cf_private branch April 17, 2019 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lilyball @veprbl @GrahamcOfBorg